Problem/Motivation

jQuery 3.5.1 has been released https://github.com/jquery/jquery/releases/tag/3.5.1

Proposed resolution

Update to the latest version of jQuery.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

jQuery has been updated from 3.4.1 to 3.5.1.

CommentFileSizeAuthor
#9 interdiff-89x.txt602 byteslauriii
#9 3136604-8-89x.patch549.33 KBlauriii
#9 interdiff-90x.txt563 byteslauriii
#9 3136604-8-90x.patch549.5 KBlauriii
#5 interdiff-89x.txt11.31 KBlauriii
#5 3136604-5-89x.patch549.29 KBlauriii
#5 interdiff-90x.txt11.47 KBlauriii
#5 3136604-5-90x.patch549.46 KBlauriii
#2 3136604-2.patch537.99 KBlauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 3136604-2.patch537.99 KB

xjm credited justafish.

xjm’s picture

xjm
she/her
Primary language English
commented
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3136604-5-90x.patch549.46 KB
new interdiff-90x.txt11.47 KB
new 3136604-5-89x.patch549.29 KB
new interdiff-89x.txt11.31 KB
effulgentsia’s picture

effulgentsia commented
Status: Needs review » Reviewed & tested by the community

Looks great.

catch’s picture

catch
he/him
Primary language English
commented

Not sure if it is my local, but I'm getting errors from the git commit hooks trying to commit this. First js patch I've tried to commit since the nodejs dependency increase so it could be related to that but could also be a real problem...

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Needs work

Same:

/Users/xjm/git/maintainer/core/misc/dialog/dialog.ajax.es6.js
  112:47  error  Replace `/^#/,·''` with `⏎··········/^#/,⏎··········'',⏎········`  prettier/prettier
✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3136604-8-90x.patch549.5 KB
new interdiff-90x.txt563 bytes
new 3136604-8-89x.patch549.33 KB
new interdiff-89x.txt602 bytes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Needs review
effulgentsia’s picture

effulgentsia commented
Status: Needs review » Reviewed & tested by the community

I disagree that that makes it "prettier", but it results in no change to the transpiled JS, so back to RTBC.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

  • catch committed 741df0e on 9.0.x 
    Issue #3136604 by lauriii, xjm, effulgentsia, justafish: Update to...

  • catch committed a0e26e5 on 8.9.x 
    Issue #3136604 by lauriii, xjm, effulgentsia, justafish: Update to...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

That one worked! Committed/pushed to 9.1.x, cherry-picked to 9.0.x, and also the 8.9.x patch there.

  • catch committed 287cbe2 on 9.1.x 
    Issue #3136604 by lauriii, xjm, effulgentsia, justafish: Update to...
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +9.0.0 release notes, +8.9.0 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.