Remove '@group legacy' from tests that do not exercise deprecated code

Removed @group legacy tags from test

We can't just remove it from all places, we do need the legacy group when we are testing deprecations.

#3135302: Remove Symfony 3 legacy test from ReverseProxyMiddlewareTest covers one of these as well, maybe this should be a meta to review each of these and have child issues for any we find that need to be removed - as in that case some may need more than just the group removing? Not sure.

Hi @shimpy, I have assigned this issue to me and was working on it..i feel its unethical.
But anyways..no issues.

Removed @group legacy tags from test and corrected errors in patch #3, found in dispatcher result.

Thanks for working on this.

1. +++ b/core/modules/user/tests/src/Unit/Views/Argument/RolesRidTest.php
   @@ -19,8 +19,6 @@ class RolesRidTest extends UnitTestCase {
       * Note this is only a legacy test because it triggers a call to
       * \Drupal\Core\Entity\EntityTypeInterface::getLabelCallback() which is mocked
       * and triggers a deprecation error. Remove when ::getLabelCallback() is
   

   This whole comment can be removed now, because getLabelCallback() has been removed too.

2. +++ b/core/tests/Drupal/Tests/Core/Asset/AssetResolverTest.php
   @@ -114,7 +114,6 @@ protected function setUp(): void {
       * Note the legacy group is used here because
       * ActiveTheme::getStyleSheetsRemove() is called and is deprecated. As this
   

   This comment block can be removed too.

3. +++ b/core/tests/Drupal/Tests/Core/StackMiddleware/ReverseProxyMiddlewareTest.php
   @@ -88,7 +88,6 @@ public function reverseProxyEnabledProvider() {
   -   * @group legacy
   

   This whole test can be removed, but let's leave this for #3135302: Remove Symfony 3 legacy test from ReverseProxyMiddlewareTest

4. +++ b/core/tests/Drupal/Tests/Listeners/DrupalStandardsListenerTrait.php
   @@ -180,8 +180,6 @@ public static function errorHandler($type, $msg, $file, $line, $context = []) {
   -   * @group legacy
   -   *
   

   This shouldn't be removed, please read the comment above.

@longwave thanks for your review , i have covered point no 1 , 2 and 4 in this patch as mentioned in #10. Point number 3 is leave for #3135302: Remove Symfony 3 legacy test from ReverseProxyMiddlewareTest.

Thanks! Two tiny nitpicks then this is good to go:

1. +++ b/core/modules/user/tests/src/Unit/Views/Argument/RolesRidTest.php
   @@ -19,12 +19,6 @@ class RolesRidTest extends UnitTestCase {
       * @covers ::titleQuery
       *
   -   * @group legacy
   

   There is an empty comment line at the end of the comment that can now be removed.

2. +++ b/core/tests/Drupal/Tests/Core/Asset/AssetResolverTest.php
   @@ -114,12 +114,7 @@ protected function setUp(): void {
   -   * @group legacy
       *
   -   * Note the legacy group is used here because
   

   There is an empty comment line at the end of the comment that can now be removed.

Empty comment line are removed from core/modules/user/tests/src/Unit/Views/Argument/RolesRidTest.php and core/tests/Drupal/Tests/Core/Asset/AssetResolverTest.php files.

Thanks, this looks perfect now!

Saving reviewer and reporter credits.

Needs rerolling.

Re-rolled patch please review.

Please review!

Thanks for rerolling.

#21 looks good, same as #14 with ReverseProxyMiddlewareTest removed as that was committed separately.

Random fail in WidgetUploadTest, back to RTBC.

Committed and pushed 409af2de16 to 9.1.x and 00798cc725 to 9.0.x. Thanks!

This is an important fix to ensure we're not triggering deprecated code. Nice work everyone.

Backported to 9.0.x as this is a test-only fix.