Currently the field settings form sets the default value to 80 (4 stars) if a value has not been set. There's a comment that this is "to prevent error during rating settings save." Zero stars is a reasonable default value for the field, especially if it is not a required field. Adding a patch that changes the default value to 0 on the settings form if it hasn't previously been set. As far as I can tell, this isn't causing any issues on save.
It'd also be nice to have a cleaner way to reset a default value back to 0 if it's already been set, but that's probably a separate issue. Right now you need to use the inspector to unhide the hidden select list to choose the no stars option.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | zeroStarsDefaultValue-3136330-2.patch | 1.21 KB | mrweiner |
Comments
Comment #2
mrweiner commentedComment #3
mrweiner commentedComment #4
mrweiner commentedhmm, this 0 value doesn't seem to be respected when the widget is rendered.
Comment #5
mrweiner commentedScratch that -- it actually renders fine. Just needed a cache clear.
Comment #6
init90Hi, I added it but don't remember details. I think it really was needed at that moment...
I just tested your patch and haven't got any errors. Tomorrow I'll test it more detailed to ensure that everything is ok and try to find a purpose for adding that check.
It would be cool to remove that hack, thanks.
Comment #7
init90Before the code was added we got next error "This value should be of the correct primitive type." when saving fivestar field configuration. This check fixed the error.
But later we added a better check in
\Drupal\fivestar\Plugin\Field\FieldType\FivestarItem::isEmptymethod which fixed the problem in more propper way.So the code certainly can be removed, thanks @mrweiner
Comment #8
mrweiner commentedThat makes sense. Great, no problem!
Comment #10
tr commentedCommitted. Thanks.