The installation on Drupal 9 crashes after including the patched entity.manager and courier dependency
with the following exception:

Uncaught PHP Exception Drupal\\Core\\Config\\Schema\\SchemaIncompleteException: "Entity type 'Drupal\\Core\\Config\\Entity\\ConfigEntityType' is missing 'config_export' definition in its annotation" at /var/www/drupal9/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php line 251

CommentFileSizeAuthor
#13 config-export-definition-3135740-13.patch2.69 KBu_tiwari
#12 config-export-definition-3135740-12.patch2.69 KBu_tiwari
#11 config-export-definition-3135740-11.patch2.69 KBu_tiwari
#9 3135740-9.patch2.67 KBchrisla
#6 3135740-6.patch2.79 KBandypost
#2 drupal9_compatibility.patch7.22 KBnorwegian.blue

Issue fork rng-3135740

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tom.drupal created an issue. See original summary.

norwegian.blue’s picture

norwegian.blue commented
StatusFileSize
new drupal9_compatibility.patch7.22 KB

I have managed to get the latest 3.x-dev commit installed in Drupal9 by applying the attached patch.
No functional testing has been performed .
Please review.

s_bhandari’s picture

s_bhandari commented

Hi @nzpling,

Please add this for test and if all the test cases get passed, please change the status to 'Needs Review'.

Thanks.

sorlov’s picture

sorlov commented
Issue tags: +Drupal 9 compatibility
andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3157334: Drupal 9: compatibility - Deprecated code

Please keep scope of the issue to fix the annotation, other issue to clean up remaining deprecations is

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
Parent issue: » #3109592: Roadmap for 3.0.0 release
StatusFileSize
new 3135740-6.patch2.79 KB

Module has no automated tests enabled so no reason to add tests

Here's a patch with limited scope defined in issue summary

mandclu’s picture

mandclu commented
Status: Needs review » Reviewed & tested by the community

As described in the OP, Drupal 9 encounters a fatal error after installing RNG. The patch in #6 resolved it for me.

chrisla’s picture

chrisla commented
Status: Reviewed & tested by the community » Needs work

As per this issue -- https://www.drupal.org/project/rng/issues/3202298 -- the patch is not correct

chrisla’s picture

chrisla commented
StatusFileSize
new 3135740-9.patch2.67 KB

Re-rolled patch from #6 with fix from https://www.drupal.org/project/rng/issues/3202298

u_tiwari made their first commit to this issue’s fork.

u_tiwari’s picture

u_tiwari commented
StatusFileSize
new config-export-definition-3135740-11.patch2.69 KB

I found that for `EventTypeRule` entity, `machine_rule` key is missing for `config_export` annotation.
Added it here.

u_tiwari’s picture

u_tiwari commented
StatusFileSize
new config-export-definition-3135740-12.patch2.69 KB

I found that for `EventTypeRule` entity, `machine_rule` key is missing for `config_export` annotation.
Added it here. (fixed a small typo done in #11)

u_tiwari’s picture

u_tiwari commented
StatusFileSize
new config-export-definition-3135740-13.patch2.69 KB

small Update to #12 to fix fatal error

mandclu’s picture

mandclu commented
Status: Needs work » Needs review
makesburbulis’s picture

makesburbulis commented

#13 works for me.

  • u_tiwari authored 3262490 on 3.x 
    Issue #3135740 by u_tiwari, endless_wander, andypost, norwegian.blue,...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

I cannot fully determine yet if the config_export is correct everywhere, but since it blocks installs and proper test results, I committed #13 anyway.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.