For compatibility with D9, add core_version_requirement: ^8 || ^9 to info.yml file.

CommentFileSizeAuthor
#18 colordialog-d9-support-3135491-18.patch1.95 KBszeidler
#15 colordialog_d9_compatibility_3135491_15.patch3.89 KBadinac
#11 Screenshot 2020-05-26 at 12.44.13 PM.png36.75 KBkunalgautam
#7 interdiff_3-7.txt1.59 KBankitsingh0188
#7 3135491-7.patch1.96 KBankitsingh0188
#7 after_patch.png16.19 KBankitsingh0188
#3 drupal_9_compatible-3135491-3.patch336 bytessarvjeetsingh

Comments

sarvjeetsingh created an issue. See original summary.

sarvjeetsingh’s picture

sarvjeetsingh commented
Assigned: sarvjeetsingh » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal_9_compatible-3135491-2.patch336 bytes

added core_version_requirement: ^8 || ^9 to info.yml file.

sarvjeetsingh’s picture

sarvjeetsingh commented
StatusFileSize
new drupal_9_compatible-3135491-3.patch336 bytes

added core_version_requirement: ^8 || ^9 to info.yml file.

meghasharma’s picture

meghasharma commented
Status: Needs review » Needs work

please provide the screenshots of rector and drupal_check command..

meghasharma’s picture

meghasharma commented

its giving error while run the drupal_check command
please fix these errors..
drupal-8.8.1 % vendor/bin/drupal-check -ad modules/contrib/colordialog
Warning: Class 'PHPUnit\Framework\MockObject\Matcher\InvokedRecorder' not found in /Users/Documents/standar_drupal/drupal-8.8.1/core/tests/bootstrap.php on line 197
2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ----------------------------------------
Line colordialog.install
------ ----------------------------------------
16 Function libraries_get_path not found.
------ ----------------------------------------

------ -------------------------------------------
Line src/Plugin/CKEditorPlugin/ColorDialog.php
------ -------------------------------------------
25 Function libraries_get_path not found.
------ -------------------------------------------

[ERROR] Found 2 errors

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
Assigned: Unassigned » ankitsingh0188
ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
Assigned: ankitsingh0188 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new after_patch.png16.19 KB
new 3135491-7.patch1.96 KB
new interdiff_3-7.txt1.59 KB

Created the patch and make it compatible with D9.
after applying patch

priyanka.sahni’s picture

priyanka.sahni commented
Assigned: Unassigned » priyanka.sahni
priyanka.sahni’s picture

priyanka.sahni commented
Assigned: priyanka.sahni » Unassigned
kunalgautam’s picture

kunalgautam commented
Assigned: Unassigned » kunalgautam
kunalgautam’s picture

kunalgautam commented
Assigned: kunalgautam » Unassigned
StatusFileSize
new Screenshot 2020-05-26 at 12.44.13 PM.png36.75 KB

This module is compatible with Drupal version 9.

Test with the drupal-check utility and found 0 errors. For me it's RTBC.

Ravi_3596’s picture

Ravi_3596 commented

The patch #7 works fine for me. It would be better if we merge patch in dev branch to make module compatible with D9.

Ravi_3596’s picture

Ravi_3596 commented
Status: Needs review » Reviewed & tested by the community
ggh’s picture

ggh commented

When can we expect a stable release for this module ported for Drupal 9,Can we have some timelines

adinac’s picture

adinac commented
StatusFileSize
new colordialog_d9_compatibility_3135491_15.patch3.89 KB
Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented

Per #15, can you please provide context for the patch, and how this differs from the work in #7?

szeidler’s picture

szeidler
Primary language German
Location Berlin
commented

Wouldn't it be better to drop the libraries dependencies and use the new core service for it? See https://www.drupal.org/node/3099614

szeidler’s picture

szeidler
Primary language German
Location Berlin
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new colordialog-d9-support-3135491-18.patch1.95 KB

Here would be an example, without using the libraries module at all.

  • szeidler authored 9982594 on 8.x-1.x 
    Issue #3135491 by szeidler, kkalashnikov: Drupal 9 readiness
g_miric’s picture

g_miric commented
Status: Needs review » Fixed
g_miric’s picture

g_miric commented
Status: Fixed » Closed (fixed)