May 18, 2020 - Meeting Agenda [#3135480]

Meeting Agenda

Introductions
Status
Alpha release requirements
Issue updates and discussion
Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every Monday at 2pm GMT (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here and leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3135480: May 18, 2020 - Meeting Agenda

mtift (he/him)	Thank you for coming!
Indrajith KB	Hi...
Ankit Singh	Hi
Priyanka Sahni	Hi
Kunal Gautam	Hello
mherchel	Morning!
Putra Bonaccorsi	Good morning/afternoon!
Nitesh	hi
komal k	Hi! :wave:
jyoti mishra	Hi
kishor kolekar	hi
brianperry	Hey there.
andrewozone	Hello
Tejas Shah	Hi
Atul Sharma	Hello All
Webbeh (he/him)	Good morning, all!
Hansa	Hey :wave:
AmyJune (volkswagenchick she/her)	Good day everyone!
Sagar	Hello
shaal	Hi
codersukanta	Hi
JayKandari	Jaideep, from India. Joining in late to sync with latest updates in Olivero. :slightly_smiling_face:

1️⃣ Status updateOur path to beta is currently headed towards Drupal 9.1. #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

mtift (he/him)	Let's use this issue to discuss the overall status of the initiative, and we'll discuss specific issues in later threads. How would you describe the progress towards the goal in one sentence?
mherchel	We released the first alpha on Friday! I’m currently writing a blog post
mherchel	Still a good amount of work to do, especially in the accessibility area, but its a big milestone
Nitesh	sounds great
jyoti mishra	Thats really nice!!
Putra Bonaccorsi	Here's the direct link to the alpha1 release tag - https://www.drupal.org/project/olivero/releases/8.x-1.0-alpha1
Putra Bonaccorsi	Congrats all!! :tada:
Kunal Gautam	Cool :+1:
Ankit Singh	Nice :thumbsup:
Hansa	Worked on #3136549: Theme search results (edited)
mherchel	The next steps are to put together an issue to discuss the requirements for beta, and work toward that
Priyanka Sahni	:+1:
Tejas Shah	I guess we should also add the dark option to the theme ?
mherchel	We need designs for that first
mherchel	It’s not really MVP, but if we are able to, it’d be a nice feature to add
Putra Bonaccorsi	@Tejas Shah We have an option issue created for the dark theme here - #3086514: Investigate use of the changing color themes for Olivero
Atul Sharma	how about creating a issue around this and see if someone from us may pick this up
codersukanta	Nice :+1:
jyoti mishra	sure @Atul Sharma
Gábor Hojtsy (he/him)	tweeted the good news about the alpha :slightly_smiling_face: https://twitter.com/DropIsMoving/status/1262386433219796997
Tejas Shah	@Putra Bonaccorsi so this would be an option for all user to switch between dark mode simply with a toggle button rgt? is this covered in that issue or just providing an color theme is the scope of that issues?
Putra Bonaccorsi	@Tejas Shah Great question! I think that still yet to be determined. Please feel free to include your feedback and ideas in the issue thread.
Tejas Shah	sure, actually this is in trend as a design principle as it has many benefits will find an authentic doc regarding the same as a supporting doc thank you (edited)
JayKandari	Great news… Congrats team on first alpha release.. :heart:

2️⃣ Issue updates and status

mtift (he/him)	What issues need some extra discussion?
Indrajith KB	#3130243: Olivero's default input element background color doesn't differentiate between disabled color
Indrajith KB	after the last release facing some issue.
Atul Sharma	Will be great if some UI expert reviews it get this patch commited into olivero
Putra Bonaccorsi	Thank you to @brianperry for submitting a patch for this issue (see link - #3136371: PHP error when enabling Olivero when with minimal profile#comment-13617880).I think the optional install config is a good stop-gap solution for minimal profile install, however, we need to figure out a nice fallback solution for missing olivero_hero and secondary menu on the minimal install, since we dependencies can be installed. What do folks think about this issue? (edited)
Indrajith KB	#3137365: Date form element is unthemed since last commits
mherchel	I’m currently working with @kostyashupenko on #3137365: Date form element is unthemed since last commits.tl;dr there are some regressions to some of the form input types, and he wants to revert my prev commit and try again.I’m going to document all of the issues that I’ve identified that my commit fixes, so we can make sure they’re resolved
Indrajith KB	Tht's great...it will solve my concern also..please check this also [#3130243]here also am done with input field. (edited)
Atul Sharma	#3135511: Create basic test coverage for Olivero theme
Atul Sharma	some progress is seen to this
brianperry	Regarding the minimal install, I actually looked at including search and image as dependencies since themes can do that now, but apparently they can't yet be forced to be installed. #3100374: Make it possible to install dependent modules when installing theme Long term that seems like it would be the best approach, but it remains to be seen how long it will take that issue to be wrapped up (especially considering how long the initial issue took to resolve)
Putra Bonaccorsi	@brianperry That's a great point! I think we need to note this in the get started page of the Olivero so that users understand the limitation of the minimal install. Also, we need to have a fallback image style when olivero_hero can't be installed. This is the same for the search_form_narrow and search_form_wide blocks. (edited)
brianperry	When you say fallback image style, you just mean something more general in the CSS?
brianperry	Not sure how we can create a fallback for the search form since the issue there is that the search module isn't installed at all in the minimal profile...
Putra Bonaccorsi	I was thinking more of the out of the box large image style, but we can look into adjusting the sizes and display of the hero image using CSS. That means that we'll be using the original uploaded image size.
Putra Bonaccorsi	Not sure how we can create a fallback for the search form since the issue there is that the search module isn't installed at all in the minimal profile...yeah, I think we need to note in the "Get Started" page that Search is not available for on minimal install, but can be visible if the module is enabled. @mherchel What do you think?
mherchel	I want to do some testing… but that sounds good to me
Putra Bonaccorsi	@mherchel Sounds good! Feel free to commit this patch that @brianperry submitted after your testing. #3136371: PHP error when enabling Olivero when with minimal profile#comment-13617880
brianperry	We couldn't even use the large image style right now - believe it or not the image module isn't installed in minimal. So if they can't be dependencies of the theme, we'd need to focus on ways to make things work if they are later enabled.

3️⃣ Where can people help this week?

mtift (he/him)	Add suggestions here
Indrajith KB	Need more testing...
Atul Sharma	The test coverage issue still needs more work
Nitesh	@mtift (he/him) can we make the social media icon configurable from theme settings?
Atul Sharma	we also need to work on the accessibility aspect as I see also been pointed to by Gabor Hojtsy
Nitesh	yaa accessibility is the main issue which we must have to work on priority basis and this also require more testing efforts.
Putra Bonaccorsi	@Atul Sharma I believe Gabor is referencing the section of the drupal.org page (see attached) and not the background accessibility issue within the Olivero theme. Andrew made a similar comment about the heading font weight as well. However, let me know if I'm incorrect about this.
Putra Bonaccorsi	Nonetheless, making sure theme hits all of the accessibility requirements is definitely top of the list. :+1:
JayKandari	Regarding Test coverage, as @Putra Bonaccorsi mentioned in comment.Can anyone test this against 9.0.x branch ?#3135511: Create basic test coverage for Olivero theme#comment-13608364Yup. Agreed @Atul Sharma, Testing scenarios will grow accordingly.. :slightly_smiling_face:Thanks !!

Participants:

mtift (he/him), Indrajith KB, Ankit Singh, Priyanka Sahni, Kunal Gautam, mherchel, Putra Bonaccorsi, Nitesh, komal k, jyoti mishra, kishor kolekar, brianperry, andrewozone, Tejas Shah, Atul Sharma, Webbeh (he/him), Hansa, AmyJune (volkswagenchick she/her), Sagar, shaal, codersukanta, JayKandari, Gábor Hojtsy (he/him)