All the JS in inline_entity_form\js\inline_entity_form.js is between block comments, and thus is not doing anything at all.
It looks like it was a 1-to-1 port from D7 from D7 => D8, afterwards got the block comments and was never deleted.

I say: Sink it!

CommentFileSizeAuthor
#3 3135207-3.patch1.21 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3135207-3.patch1.21 KB

Patch to remove inline_entity_form\js\inline_entity_form.js attached.

spokje’s picture

spokje
Primary language Dutch
commented
Title: inline_entity_form\js\inline_entity_form.js Hasn't got any usuable code in it » inline_entity_form\js\inline_entity_form.js Hasn't got any useful le code in it
spokje’s picture

spokje
Primary language Dutch
commented
Title: inline_entity_form\js\inline_entity_form.js Hasn't got any useful le code in it » inline_entity_form\js\inline_entity_form.js Hasn't got any useful code in it
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs review » Fixed

Thanks a lot for raising this ant the other issues. It's a great contribution to make that messy and convoluted codebase more maintainable.

Code looks good, all dead code. Also found one usage of the library and removed that on commit.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

@Spokje: It looks to me that this applies the commerce-product.css and its library definition too. A grep for "commerce" or "base" shows no usage. Can you cross-check that?

commerce_product.base:
  version: VERSION
  css:
    theme:
      css/commerce-product.css: {}
spokje’s picture

spokje
Primary language Dutch
commented

@geek-merlin: Ah, I actually never look that deep into commerce-product.css...

Now that I did: Dead (code) as a Dodo (code)...
Erm...
Yeah, not used anywhere I can see. And again: an exact copy of the D7-version: commerce-product.css

I think (since commerce-product.css is alphabetically the first one) this one was added to the library file as a test to see how things worked in D8 and forgotten afterwards, with the 2 other CSS-files never even making it to inclusion in the library file.

Kill, Fire, etc :)

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

Thanks! Removed them too.

  • geek-merlin committed 3f8adf6 on 8.x-1.x 
    Issue #3135207 by Spokje, geek-merlin: inline_entity_form\js\...
  • geek-merlin committed 93350c9 on 8.x-1.x authored by Spokje
    Issue #3135207 by Spokje: inline_entity_form\js\inline_entity_form.js...
  • geek-merlin committed cfcf213 on 8.x-1.x
    Amended Issue #3135207 by Spokje: inline_entity_form\js\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.