[D8] Go Back History

Thank you for contribution!!!

I am updating the git instructions and also reviewed the compatible with D9.You can add core_version_requirement: ^8 || ^9 in module. info file.

Code Looks Good !

ankushgautam@GGN-199732-C02ZT1F1MD6V contrib % drupal-check go_back_history
2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

Hi marco.aresu

Sorry, the report was added by mistake . Now Code looks good for me

Thank you for your contribution!

Review of the 8.x-1.x branch (commit d59bd12):looks good to me.

Drupal.behaviors.goBackHistory = {
    attach: function (context, settings) {
      $('.go-back-history-btn').click(function () {
        window.history.back();
      });
    }
  };

This code adds multiple same click events to the each button.
Drupal behaviors calls multiple times and in most cases you should use jQuery.once to prevent multiple code execution on the same element.
You can see examples on the js api overview page:
https://www.drupal.org/docs/8/api/javascript-api/javascript-api-overview

/**
 * Implements hook_page_attachments().
 */
function go_back_history_page_attachments(array &$page) {
  $page['#attached']['library'][] = 'go_back_history/go_back_history';
}

This code adds module library on each page without any checks, even if block does not exists, better to attach it to the block plugin
render array.

go_back_history:
  css:
    theme:
      css/go_back_history.css: {}
  js:
    js/go_back_history.js: {}

If library uses jquery, documentation says that better to add it as dependency.
https://www.drupal.org/node/2216195

@marco.aresu,
Please avoid to use DOM element inside the class file.

$content = "<a class='go-back-history-btn'>" . $this->t('Go back') . "</a>";

Instead, create a twig file and place the DOM code inside the file.

For template suggestion, add the below code in .module file.

/**
 * Implements hook_theme().
 */
function go_back_history_theme() {
  return array(
    'go_back_history_block' => array(
      'variables' => array('buttonVal' => NULL),
      'template' => 'block--go--back--history',
     ),
   );
}

Add the below code in the class file.

public function build() { 
  return array(
    '#buttonVal' => $this->t('Go back'),    
  );
}

The twig file "'block--go--back--history.html.twig" will look like below,

{#
/**
 * @file
 * go_back_history custom block.
 */
#}
<a class="go-back-history-btn">{{ buttonVal }}</a>

@marco,

Have you tried the below option to attach library and theme file?

public function build() { 
  return [
    '#theme' => 'go_back_history_block',
    '#buttonVal' => $this->t('Go back'),
    '#attached' => [
        'library' => [
          'go_back_history/go_back_history',
        ],
      ],    
  ];
}

Thank you for your contribution! I am going to update the project to opt it into security coverage.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.