It looks like all deprecations had been removed from this module, but in the meantime a new method was deprecated. So that latest dev is not compatible with Drupal 9 anymore.

vendor/bin/drupal-check web/modules/contrib/auto_entitylabel/
14/14 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ---------------------------------------------------------------------------
Line tests/src/Kernel/AutoEntityLabelTest.php
------ ---------------------------------------------------------------------------
76 Call to deprecated method getUsername() of class Drupal\user\Entity\User:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Session\AccountInterface::getAccountName() or
\Drupal\user\UserInterface::getDisplayName() instead.
------ ---------------------------------------------------------------------------

[ERROR] Found 1 error

CommentFileSizeAuthor
#3 3134497-3.patch563 bytesmunish.kumar
#3 Screen Shot 2020-05-08 at 11.46.37 AM.png36.6 KBmunish.kumar

Comments

GaëlG created an issue. See original summary.

munish.kumar’s picture

munish.kumar commented
Assigned: Unassigned » munish.kumar
munish.kumar’s picture

munish.kumar commented
Assigned: munish.kumar » Unassigned
Status: Active » Needs review
StatusFileSize
new Screen Shot 2020-05-08 at 11.46.37 AM.png36.6 KB
new 3134497-3.patch563 bytes

Here is the updated patch and screenshot to fix this test case issue.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Novice 
/var/www/html/d8/web/modules/contrib$ git clone --branch 8.x-3.x git@git.drupal.org:pro ject/auto_entitylabel.git
Cloning into 'auto_entitylabel'...
remote: Enumerating objects: 887, done.
remote: Counting objects: 100% (887/887), done.
remote: Compressing objects: 100% (358/358), done.
remote: Total 887 (delta 539), reused 851 (delta 518), pack-reused 0
Receiving objects: 100% (887/887), 159.55 KiB | 477.00 KiB/s, done.
Resolving deltas: 100% (539/539), done.
/var/www/html/d8/web/modules/contrib$ cd auto_entitylabel/
/var/www/html/d8/web/modules/contrib/auto_entitylabel$ wget https://www.drupal.org/files/issues/2020-05-08/3134497-3.patch
--2020-05-10 13:05:55--  https://www.drupal.org/files/issues/2020-05-08/3134497-3.patch
Resolving www.drupal.org (www.drupal.org)... 151.101.114.217
Connecting to www.drupal.org (www.drupal.org)|151.101.114.217|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 563 [text/plain]
Saving to: '3134497-3.patch'
3134497-3.patch               100%[==============================================>]     563  --.-KB/s    in 0s
2020-05-10 13:05:55 (13.0 MB/s) - '3134497-3.patch' saved [563/563]
/var/www/html/d8/web/modules/contrib/auto_entitylabel$ git apply -v 3134497-3.patch
Checking patch tests/src/Kernel/AutoEntityLabelTest.php...
Applied patch tests/src/Kernel/AutoEntityLabelTest.php cleanly.

D8 test installation does not show any hickups while testing with patch applied.

No flaws, no harm, no arguable code injection or drastic changes here ... so quick and dirty RTBC.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Title: Call to deprecated method getUsername() of class Drupal\user\Entity\User: in drupal:8.0.0 and is removed from drupal:9.0.0. » Replace call to deprecated method getUsername with getAccountName

  • diqidoq committed e0b8ab3 on 8.x-3.x authored by munish.kumar 
    Issue #3134497 by munish.kumar, diqidoq: Replace call to deprecated...
dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Reviewed & tested by the community » Fixed

Thanks! +1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.