On /admin/config/people/legal/users, it mentions version and revision, but it isn't obvious what the difference is.

On /admin/config/people/legal/terms_history both version and revision appear, but in all my tests, I've only seen version changing, not revision.

On /admin/config/people/legal, "Version" appears twice:

screenshot

CommentFileSizeAuthor
#3 3134411-3-fix-typo.patch489 bytesfjgarlin
legal.png9.43 KBmalcomio

Issue fork legal-3134411

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

malcomio created an issue. See original summary.

malcomio’s picture

malcomio commented
Issue summary: View changes
fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review
StatusFileSize
new 3134411-3-fix-typo.patch489 bytes

I checked the code and it's actually a typo (kind of). That second "version" string is actually "revision".
Attached patch to fix that.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Terminology of versions and revisions is confusing » Revision label shown as "Version" (likely a "copy paste" mistake)
Status: Needs review » Reviewed & tested by the community

Looks good to me. Updating title to address the problem more specifically.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Is the issue also present in 2.x? Then it should be fixed there. Could someone please check that?

fjgarlin’s picture

fjgarlin commented
Version: 8.x-1.x-dev » 2.0.x-dev

fjgarlin opened merge request !10

fjgarlin’s picture

fjgarlin commented

Correct. The 2.x version still has the same issue. I created an MR with the same fix.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @fjgarlin confirming RTBC! So #3 is against 8.x-1.x and the MR!10 is against 2.0.x!

  • Robert Castelo committed 8bb9a408 on 3.0.x 
    Issue #3134411 by fjgarlin: Revision label shown as "Version" (likely a...
robert castelo’s picture

robert castelo commented
Version: 2.0.x-dev » 3.0.x-dev
robert castelo’s picture

robert castelo commented
Status: Reviewed & tested by the community » Fixed

Thanks fjgarlin and everyone who reviewed this patch!

I've added this to the new 3.x.0 branch that's compatible with Drupal 8.9, 9, and 10.

Will do a full release with other fixes included today.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.