Problem/Motivation

IMCE browser not opening for a large number of image files. Because for every file IMCE trying to get image size which is causing PHP timeout issue.

Proposed resolution

Providing a common setting to disable get image size call than pass default width and height.

CommentFileSizeAuthor
#21 imce-pager.patch4.5 KBsany_86@bk.ru
#20 imce-IMCE_browser_not_loading_for_larger_number_of_images-3134212-d10-20.patch3.07 KBmanish.upadhyay
#19 imce-IMCE_browser_not_loading_for_larger_number_of_images-3134212-d8-19.patch5.58 KBpawel_r
#12 imce-IMCE_browser_not_loading_for_larger_number_of_images-3134212-d8-11.patch5.59 KBpaulocs
#10 Screenshot from 2020-06-18 18-08-44.png265.56 KBthalles
#9 imce-IMCE_browser_not_loading_for_larger_number_of_images-3134212-d8-9.patch4.3 KBpaulocs
#2 IMCE-browser-not-loading-3134212-1.patch3.43 KBrahul.nahar001

Issue fork imce-3134212

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rahul.nahar001 created an issue. See original summary.

rahul.nahar001’s picture

rahul.nahar001 commented
StatusFileSize
new IMCE-browser-not-loading-3134212-1.patch3.43 KB
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

What will be a large numbers of images?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

I tested with 4877 images, and if you use thumbnail is realy slow, but if you use a list simple, the time of load is good

rahul.nahar001’s picture

rahul.nahar001 commented

Hi There are 2 scenarios

  1. We have enabled s3fs module
  2. We have around 20k+ images
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

So, to test this, do I need an AWS account?

rahul.nahar001’s picture

rahul.nahar001 commented

Yes, This issue occurs when we point the file system to the S3 bucket. So you need an AWS account to replicate this issue.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Active » Needs work

This feature, like was implemented, broken the resize feature

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Assigned: rahul.nahar001 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new imce-IMCE_browser_not_loading_for_larger_number_of_images-3134212-d8-9.patch4.3 KB

Hello,
follow a new patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new Screenshot from 2020-06-18 18-08-44.png265.56 KB

Apparently, there is still a bug in resizing, see:

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Needs work
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Needs review
StatusFileSize
new imce-IMCE_browser_not_loading_for_larger_number_of_images-3134212-d8-11.patch5.59 KB

Follow a new patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Reviewed & tested by the community

Works fine to me!
Thanks @all for this amazing job!

  • thalles committed da4007f on 8.x-2.x authored by paulocs 
    Issue #3134212 by paulocs, rahul.nahar001, thalles: IMCE browser not...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed
rahul.nahar001’s picture

rahul.nahar001 commented

Hi @thalles,

Is there any plan for a new release?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Assigned: Unassigned » ufku

I will create a issue to this, but I don't heve permission to this

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pawel_r’s picture

pawel_r commented
StatusFileSize
new imce-IMCE_browser_not_loading_for_larger_number_of_images-3134212-d8-19.patch5.58 KB

Patch for IMCE 2.4. It removes all info from image: size, date width and height. Thumbnail feature will not work.

manish.upadhyay’s picture

manish.upadhyay commented
StatusFileSize
new imce-IMCE_browser_not_loading_for_larger_number_of_images-3134212-d10-20.patch3.07 KB

Hi,

Here is the patch for D10 compatible version.

Thanks,

sany_86@bk.ru’s picture

sany_86@bk.ru commented
StatusFileSize
new imce-pager.patch4.5 KB

It looks like all the patches simply remove all information from the image: size, date width and height. And miniatures too.

I would like to bring to your attention a slightly different approach to solving this problem. Instead of simplifying the display of pictures and disabling information about them, you can simply add a pager ("Prev" and "Next" buttons) and display, for example, 50 pictures at a time.
Maybe this will be useful for someone.

sany_86@bk.ru opened merge request !24