I don't create this issue as a bug report, it's probably more of a task or feature request that needs to follow the behavior described below. This isn't something unique to the Currency Taxonomy module it's more of a general problem when providing content through hook_install. This also has been described somewhere else before, maybe in core, but I can't find it right now.

When you install Currency Taxonomy from the UI or from Drush the terms get created as intended. BUT when Currency Taxonomy gets installed from configuration import drush -y cim the terms don't get created, only the vocabulary gets created.

As a workaround it probably would be a good idea to at least provide a simple form under /admin/config/content/currency_taxonomy that has a submit button to manually trigger _currency_taxonomy_add_terms() and maybe also checks if terms with the same name inside the currencies vocabulary exist yet.

Steps to reproduce

  1. Vanilla Drupal standard installation drush -y site:install --site-name="Hello World" --account-name=admin --account-pass=admin
  2. Install Currency Taxonomy -> Terms are there
  3. Export config drush -y cex
  4. Save the site UUID somewhere drush -y cget system.site uuid
  5. Drop database, reinstall Vanilla Drupal standard installation (step 1.)
  6. Set site UUID from step 3. drush -y cset system.site uuid YOUR-SITE-UUID
  7. (Fix shortcut set drush -y edel shortcut_set)
  8. Import config drush -y cim -> vocabulary is there, terms are not there

Comments

leymannx created an issue. See original summary.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Category: Task » Bug report

Ah no, switching this to bug report. There also are fields being created upon installation. But programmatically. While they probably should rather be create from Yamls inside the config/install folder.

Enabling the module from configuration without having these fields exported earlier then simply deletes these fields for not being in the currently imported config. This then prevents the terms from being created due to missing fields.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

Nah, the missing fields still don't explain it. Even with the fields exported as config, the Terms don't get created upon module installation on configuration import. But maybe putting them as Yamls in config/install would fix it.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Issue summary: View changes
binnythomas’s picture

binnythomas commented

I am facing this issue as well. The taxonomy terms get created when module is enabled from UI but not on config import. Manually enabling and disabling the module generates the taxonomy terms but leads to errors on the next import causing it to fail. 

The import failed due to the following reasons:
  Entities exist of type <em class="placeholder">Taxonomy term</em> and <em c
  lass="placeholder">Vocabulary</em> <em class="placeholder">Currency</em>. T
  hese entities need to be deleted before importing.
binnythomas’s picture

binnythomas commented

I am thinking if terms are added via hook update instead of install it might work.

abhaysaraf’s picture

abhaysaraf commented

I think, here a patch is required that checks if vocabulary and respective fields already exists.
Line 956, function _currency_taxonomy_create_taxonomy() in currency_taxonomy/currency_taxonomy.module file.

As 'drush cex' exports the vocabulary and module install tries all again.

astonvictor’s picture

astonvictor commented
Version: 8.x-1.x-dev » 2.0.0
Assigned: Unassigned » astonvictor
astonvictor’s picture

astonvictor commented
Assigned: astonvictor » Unassigned
Status: Active » Fixed

It is fixed in the issue - Moved creating vocabulary from the install hook.

+ anyway you can use drush php-eval 'currency_taxonomy_add_terms();' command to force create all terms.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.