CommentFileSizeAuthor
#11 3133793-11.patch428 bytesnitvirus
#6 3133793-6.patch408 bytesdgaspara
#2 3133793-2.patch407 bytesdgaspara

Comments

nitvirus created an issue. See original summary.

dgaspara’s picture

dgaspara commented
Status: Active » Needs review
Issue tags: +Drupal 9 compatibility, +Drupal 9 porting day, +Drupal 9 readiness
StatusFileSize
new 3133793-2.patch407 bytes

Compatible with D9. So, Add core_version_requirement: ^8 || ^9 to info.yml file.

 [OK] No errors


 1/1 [============================] 100%
nitvirus’s picture

nitvirus commented
Assigned: nitvirus » Unassigned
raunak.singh’s picture

raunak.singh commented
Assigned: Unassigned » raunak.singh
Status: Needs review » Needs work

Hi @dgaspara,
I have tested this patch on my local there is an issue I found in your patch there should be `# core: 8.x` in patch as there in term_condition.info.yml but not added in your patch please update.

raunak.singh’s picture

raunak.singh commented
Assigned: raunak.singh » Unassigned
dgaspara’s picture

dgaspara commented
StatusFileSize
new 3133793-6.patch408 bytes

Hi @Raunak.singh, please review. Thanks for your feedback!

dgaspara’s picture

dgaspara commented
Status: Needs work » Needs review
raunak.singh’s picture

raunak.singh commented
Assigned: Unassigned » raunak.singh
nitvirus’s picture

nitvirus commented

I would like both core: 8.x and core_version, as core is required by drupal versions less than 8.7

name: My Module
type: module
core: 8.x
core_version_requirement: ^8 || ^9

As per https://www.drupal.org/node/3070687

so @Raunak.singh, I think original patch at #2 should hold true.

raunak.singh’s picture

raunak.singh commented
Assigned: raunak.singh » Unassigned
nitvirus’s picture

nitvirus commented
StatusFileSize
new 3133793-11.patch428 bytes

Updated the patch as dependency had to be chnaged according to standards.

dependencies:
  - drupal:link

see node: https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

sarvjeetsingh’s picture

sarvjeetsingh commented
Status: Needs review » Reviewed & tested by the community

looks fine.
no errors reported by rector, upgrade_status and drupal-check.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Drupal 9 readiness
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Drupal 9 porting day

Porting day was April 28th so removing tag.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

Committing this just with one minor change. The core tag needs to be removed as well. I'll do that on commit.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Status: Reviewed & tested by the community » Fixed

This was committed to the 2.x branch. Thanks

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.