Problem/Motivation

The tests aren't passing on Drupal.org but they are passing on local.

Remaining tasks

Figure it out why they aren't passing on D.O and fix the tests.

CommentFileSizeAuthor
#5 3133612-3.patch2.35 KBgnuget
#5 3133612-interdiff-2-3.patch1.59 KBgnuget
#2 3133612-2.patch771 bytesgnuget

Comments

gnuget created an issue. See original summary.

gnuget’s picture

gnuget
Primary language Spanish
commented
StatusFileSize
new 3133612-2.patch771 bytes

Ok, I suspect that the problem is that the $_SERVER['HTTP_HOST'] is not defined when the tests are run on D.O.

So here my first try fixing the tests.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3133612-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 3133612-interdiff-2-3.patch1.59 KB
new 3133612-3.patch2.35 KB

The relative URL is now calculated by drupal instead of using base_url.

(Long shot because the error seems unrelated)

  • gnuget committed 4c967da on 8.x-1.x 
    Issue #3133612 by gnuget: Fix tests on D.O
gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.