CommentFileSizeAuthor
#5 interdiff-3133379-5.txt663 bytesjigish.addweb
#5 3133379-5.patch5.92 KBjigish.addweb
#4 3133379-4.patch5.09 KBjigish.addweb
#2 3133379-2.patch5.08 KBjigish.addweb

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
StatusFileSize
new 3133379-2.patch5.08 KB
baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Needs work

@jigish, I have the following comment about this patch.

+++ b/modules/cloud_service_providers/openstack/openstack.module
@@ -66,6 +80,17 @@ function openstack_update_resources(CloudConfig $cloud_config) {
+    $images = aws_cloud_get_pending_images($cloud_config->getCloudContext());

You need to create a function for openstack pending images. If you call aws_cloud_get_pending_images, it will look at the aws_cloud_image entity table.

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3133379-4.patch5.09 KB

@baldwinlouie

Thank you for your review.

I changed the function name to openstack_get_pending_images.

Please review the updated patch.

Thanks

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3133379-5.patch5.92 KB
new interdiff-3133379-5.txt663 bytes

@yas @baldwinlouie

Fixing coding standard violations.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@jigishaddweb

Thank you for the update. I included the fix of the coding violation at the patch #3135193-3. So we should review the patch #4 above.

@baldwinlouie

What do you think?

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas and @jigish

Thank you for updating the patch. It looks good to me now.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 11a0244 on 8.x-1.x authored by jigish.addweb 
    Issue #3133379 by jigish.addweb, baldwinlouie, yas: Manage OpenStack...

  • yas committed c80ce7c on 8.x-2.x authored by jigish.addweb 
    Issue #3133379 by jigish.addweb, baldwinlouie, yas: Manage OpenStack...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.