After updating IframeDefaultFormatter::iframeIframe() to return a render array instead of an HTML string, the field formatter IframeOnlyFormatter.php is passing that render array to Markup::create(), causing an error.

CommentFileSizeAuthor
#2 3133359-2.patch931 bytesagoradesign

Comments

Skabbkladden created an issue. See original summary.

agoradesign’s picture

agoradesign commented
Status: Active » Needs review
StatusFileSize
new 3133359-2.patch931 bytes
Skabbkladden’s picture

Skabbkladden commented
Status: Needs review » Reviewed & tested by the community

The patch fixes the issue.

smustgrave’s picture

smustgrave commented

Question.

The settings variable doesn't appear to be defined. Would that condition ever get it?
And if this has been tested when can it be rolled into the next release?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Major

Same problem here, I can confirm RTBC. #2 solves the problem perfectly.
Setting the priority higher as it completely breaks functionality in this case and makes it impossible to use. The page just renders "Array" (string).

Any active maintainer who can commit this?

Thanks a lot in advance.

devkinetic’s picture

devkinetic commented

This should still be rolled in!

  • agoradesign authored 49a6893 on 8.x-1.x 
    Issue #3133359 by agoradesign: Render array sent to Markup::create in...

  • 08887e9 committed on 8.x-2.x 
    Issue #3133359: Render array not cacheable with tokensupport

  • agoradesign authored 29f4018 on 8.x-2.x 
    Issue #3133359 by agoradesign: Render array sent to Markup::create in...
neffets’s picture

neffets commented
Assigned: Unassigned » neffets
Status: Reviewed & tested by the community » Fixed

Patch applied to branch 8.x-2.x

In the -1.x branch I only applied the cache=0 for tokensupport

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.