In #2913829: Conflict between allowing default time and requiring the scheduled date I added javascript tests for the new functionality. The new files are in this commit

However, this means that our Travis testing on PHP5.6 fails with

PHPUnit_Framework_Exception: Fatal error: Call to a member function execute() on null in /home/travis/build/jonathan1055/drupal/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php on line 956
Caused by:
exception 'ErrorException' with message 'unserialize(): Error at offset 0 of 171 bytes' in /home/travis/build/jonathan1055/drupal/vendor/phpunit/phpunit/src/Util/PHP.php:114

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

The test builds complete OK at PHP7+ (but the javascript tests are skipped). We have javascript test coverage on drupal.org so this is good. We can skip the test at PHP5.6 on Travis, to give a clean run. Having continual red test failure for every job will obscure any new test fault.

We cannot use the php code

static::markTestSkipped('testDefaultTimeWhenSchedulingIsRequired');

because in this situation the test has already crashed before it gets to do that. However, we can filter out the javascript test at command time

  # Do not run the Javascript tests on PHP5.6
  # See https://www.drupal.org/project/scheduler/issues/3133151
  - if [ $TRAVIS_PHP_VERSION == "5.6" ]; then
        ./vendor/bin/phpunit -c ./core/phpunit.xml.dist ./modules/$MODULE/tests/ --filter='/(?!.*Javascript)^.*$/';
      else
        ./vendor/bin/phpunit -c ./core/phpunit.xml.dist ./modules/$MODULE/tests/;
    fi

  • jonathan1055 committed 37d09e0 on 8.x-1.x 
    Issue #3133151 by jonathan1055: Skip Javascript tests on Travis at PHP5....
jonathan1055’s picture

jonathan1055 commented
Title: Javascript test for default date fail on Travis at PHP5.6 » Javascript test for default date crashes Travis at PHP5.6
Status: Active » Fixed

We now get green 'all tests passed' on Travis tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.