Closed (fixed)
Project:
Drupal core
Version:
9.1.x-dev
Component:
configuration entity system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 May 2020 at 03:05 UTC
Updated:
22 Dec 2020 at 16:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
aaronbaumanConfigEntityTypeInterface defines a getClass() method
We should just use that, which will return the specific class with the annotation issue.
One-liner
Comment #4
pavnish commentedComment #5
aaronbaumanUpdate test coverage for this change.
Comment #7
aaronbaumanFixed test coverage.
Comment #8
pavnish commentedComment #9
mvonfrie commentedFixed the patch for 9.0.x.
The method
TestCase::expectDeprecationMessageRegExp()has been renamed toTestCase::expectDeprecationMessageMatches().Comment #10
mvonfrie commentedThe patched code ends with a blank line which somehow was also shown by the IDE in the #7 patch. Removed the second blank line at the end and hope this works now.
Comment #11
mvonfrie commentedComment #12
mvonfrie commentedComment #13
mvonfrie commentedComment #14
mvonfrie commentedSorry for the clutter. It took me a while to find out that the error "trailing whitespace" actually means "windows line ending" which I forgot to change in my editor after a re-installation.
Comment #15
jungleThe test is green, but in reality, it never throws error on specific Interface, it's against specific
Class.Let's change
Mock_ConfigEntityTypeInterfacetoFooConfigEntityto make sense moreComment #16
anmolgoyal74 commentedAddressed #15
Comment #17
jungleThanks, it's ready to me.
Comment #18
jungleComment #19
alexpottCommitted and pushed b2519618b4 to 9.2.x and c8b93171c9 to 9.1.x. Thanks!