drupal-check against betterlogin 8.x-1.x-dev

drupal-check -ad modules/contrib/betterlogin                              
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------ 
  Line   src/EventSubscriber/BetterLoginSubscriber.php                                 
 ------ ------------------------------------------------------------------------------ 
  25     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------

Replacing \Drupal call with using use dependency injection .

CommentFileSizeAuthor
#5 interdiff-2-5.txt409 byteshardik_patel_12
#5 3132383-5.patch1.89 KBhardik_patel_12
#2 3132383-2.patch1.84 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new 3132383-2.patch1.84 KB

Kindly review a patch.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs review » Needs work 
+++ b/src/EventSubscriber/BetterLoginSubscriber.php
@@ -13,6 +14,22 @@ use Drupal\Core\Url;
+   *

@Hardik_Patel_12 - Can you please add short description here like - Constructs a new Better Login Subscriber object

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: Unassigned » hardik_patel_12
hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new 3132383-5.patch1.89 KB
new interdiff-2-5.txt409 bytes

Added short description for construct method in the patch , kindly review the patch.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: hardik_patel_12 » yogeshmpawar

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Needs review » Fixed

Committed & Pushed to 8.x-1.x branch & will create a new release soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -D9 readiness

Removing old tag (only use Drupal 9 compatibility).