In preparation for security review, I'm running drupal-check and https://pareview.sh/.

CommentFileSizeAuthor
#8 Screenshot from 2024-07-22 10-53-22.png121.53 KBriddhi.addweb
#8 Screenshot from 2024-07-22 10-53-54.png179.41 KBriddhi.addweb
#2 coding_standards-3132308-2.patch26.8 KBjoelsteidl

Issue fork cdnetworks_purge-3132308

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joelsteidl created an issue. See original summary.

joelsteidl’s picture

joelsteidl commented
StatusFileSize
new coding_standards-3132308-2.patch26.8 KB

This patch cleans up the majority of issues found by drupal-check.

  • joelsteidl committed 26a43d1 on 8.x-1.x 
    Issue #3132308 by joelsteidl: Coding standards in preparation for...
joelsteidl’s picture

joelsteidl commented

This will need a re-roll.

silvi.addweb made their first commit to this issue’s fork.

silvi.addweb opened merge request !2

silvi.addweb’s picture

silvi.addweb commented
Status: Active » Needs review

Hello,

I created an MR and fixed phpcs problems. Review, please.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2024-07-22 10-53-54.png179.41 KB
new Screenshot from 2024-07-22 10-53-22.png121.53 KB

I have tested this issue in version 8.9 and the mentioned phpcs issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.

lpeidro made their first commit to this issue’s fork.

lpeidro’s picture

lpeidro commented
  • I have added the GitLab CI configuration to run both static code analysis and unit tests in GitLab.
  • I have resolved some issues and added compatibility with Drupal 10.
  • I just merged it into the 2.x development branch.