2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                      
 [OK] No errors

No deprecation issues found. In my testing, all that was required was the core_version_requirement key. Patch to follow.

CommentFileSizeAuthor
#14 3130736-14.patch529 bytessahana _n
#12 3130736-12.patch529 bytesmrinalini9
#7 3130736-7.patch527 bytespcate
#2 3130736-02.patch417 bytesmarkdorison

Comments

markdorison created an issue. See original summary.

markdorison’s picture

markdorison
he/him
commented
Status: Active » Needs review
StatusFileSize
new 3130736-02.patch417 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3130736-02.patch, failed testing. View results

pcate’s picture

pcate commented
Status: Needs work » Reviewed & tested by the community
pcate’s picture

pcate commented

Patch failed for me.

pcate’s picture

pcate commented
Status: Reviewed & tested by the community » Needs work
pcate’s picture

pcate commented
StatusFileSize
new 3130736-7.patch527 bytes
pcate’s picture

pcate commented
Status: Needs work » Needs review
mattdaniel’s picture

mattdaniel commented
Status: Needs review » Reviewed & tested by the community

Tested the patch in #3130736-2: Drupal 9 compatibility and it works for me. The additional change to the description in #3130736-7: Drupal 9 compatibility seems unrelated.

martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Reviewed & tested by the community » Needs work

Maybe we also should drop old Drupal 8 versions. by removing the core: 8.x.

And change core_version_requirement: ^8 || ^9 to core_version_requirement: ^8.8 || ^9

mrinalini9’s picture

mrinalini9 commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3130736-12.patch529 bytes

Updated patch as per the changes suggested in #10, please review.

Status: Needs review » Needs work

The last submitted patch, 12: 3130736-12.patch, failed testing. View results

sahana _n’s picture

sahana _n commented
Status: Needs work » Needs review
StatusFileSize
new 3130736-14.patch529 bytes

Please review the patch.

Status: Needs review » Needs work

The last submitted patch, 14: 3130736-14.patch, failed testing. View results

pcate’s picture

pcate commented

Tested latest patch. It applied cleanly and removed all Drupal 9 deprecation warnings.

I think the CI is reporting "failed testing" because there aren't actually any tests for this module.

pcate’s picture

pcate commented
Status: Needs work » Reviewed & tested by the community
pcate’s picture

pcate commented

Is there any additional work needed with this patch? It would be great to get this merged with a new release as it is the only thing preventing this module from being Drupal 9 compatible.

  • Martijn de Wit committed 4be455e on 8.x-1.x 
    Issue #3130736 by PCate, markdorison, mrinalini9, Sahana _N, MattKD,...
martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.