Comments

mikejw created an issue. See original summary.

mikejw’s picture

Title: Add in support for footnotes extension » Add in support for more extensions
Issue summary: View changes
markhalliwell’s picture

Extensions can also have options: https://commonmark.thephpleague.com/1.4/extensions/external-links/#confi...

So, while they're not really working right now (still building that out), adding each respective extension's options to the plugin itself will help in the long run.

Also, it probably wouldn't hurt to replace the custom extensions (at link/hash link/link render) I built with the now official/supported extensions bundled with the library now (you can see how these settings were added there).

mikejw’s picture

Yeah I have started putting in the options and building the settings forms. Good idea re the custom extensions - I'll clean those up too.

mikejw’s picture

...also probably going to have to allow options per page in the case of table of contents I am thinking. Maybe put that in later.

mikejw’s picture

Status: Active » Postponed

Ok, new plan as discussed with @markcarver - going to create separate issues for each extension, starting with smart punctuation. After that one is done will continue with the rest. Postponing this one for now, will remove later.

markhalliwell’s picture

Title: Add in support for more extensions » Add support for CommonMark extensions
Category: Feature request » Plan
Issue summary: View changes
Status: Postponed » Active

This can remain open as the meta parent issue.

I've gone ahead and created the rest of the child issues.

markhalliwell’s picture

Assigned: mikejw » Unassigned
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.