FILE: ...h_api_glossary/src/Plugin/facets/processor/GlossaryAZAllItemsProcessor.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
41 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
41 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
FILE: ...s/contrib/search_api_glossary/src/Plugin/search_api/processor/Glossary.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
179 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3129553-2.patch | 1.6 KB | mo_farhaz |
Comments
Comment #2
mo_farhaz commentedplease review.
Comment #3
kristen polThanks for the issue and patch!
I'm working on creating a Drupal 9 release and am reviewing all "needs review" issues in the process.
Confirmed that the patch still applies cleanly and modifies both:
and
as expected.
The code looks okay and the change is simple, so I think this is fine to include in the next release. I'll probably be committing this today.
Comment #5
kristen polCommitted. Will be creating a new release shortly.
Comment #6
kristen polIncluded in new release: https://www.drupal.org/project/search_api_glossary/releases/8.x-4.1