jigish.addweb created an issue. See original summary.
@jigishaddweb
Thank you for adding the test cases. It looks good to me. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.
8.x-1.x
8.x-2.x
Fixed
Thank you for adding the test cases. You don't have to do the refactoring of the following code since that is a part of the repeatTestUpdateSnapshot:
repeatTestUpdateSnapshot
+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/SnapshotTest.php @@ -2,6 +2,8 @@ - /** - * Create update snapshot test cases. - * - * @return string[][] - * test cases array. - */ - private function createUpdateSnapshotTestCases(): array { - $test_cases = []; - $random = $this->random; - - // Only ID. - $test_cases[] = ['id' => 'snap-' . $this->getRandomId()]; - - // Name and ID. - $test_cases[] = [ - 'name' => 'Snapshot Name ' . $random->name(32, TRUE), - 'id' => 'snap-' . $this->getRandomId(), - ]; - - return $test_cases; - }
@yas
Thank you for testing the patch.
I changed the code as per your previous comment.
Please review new patch.
Thanks
@jigishaddweb,
I see, now I understood. Then we should put the code into AwsCloudTestFormDataTrait, not AwsCloudTestMockTrait.
AwsCloudTestFormDataTrait
AwsCloudTestMockTrait
I refactored the code.
Please review the updated patch again.
Thank you for the update. It looks good to me now. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.
Issue #3129542 by jigish.addweb, yas: Add test case for OpenStack...
Automatically closed - issue fixed for 2 weeks with no activity.
Comments
Comment #2
jigish.addweb commentedComment #3
yas@jigishaddweb
Thank you for adding the test cases. It looks good to me. I'll merge the patch to
8.x-1.xand8.x-2.xand close this issue asFixed.Comment #4
yas@jigishaddweb
Thank you for adding the test cases. You don't have to do the refactoring of the following code since that is a part of the
repeatTestUpdateSnapshot:Comment #5
jigish.addweb commented@yas
Thank you for testing the patch.
I changed the code as per your previous comment.
Please review new patch.
Thanks
Comment #6
yas@jigishaddweb,
I see, now I understood. Then we should put the code into
AwsCloudTestFormDataTrait, notAwsCloudTestMockTrait.Comment #7
jigish.addweb commented@yas
I refactored the code.
Please review the updated patch again.
Thanks
Comment #8
yas@jigishaddweb
Thank you for the update. It looks good to me now. I'll merge the patch to
8.x-1.xand8.x-2.xand close this issue asFixed.Comment #11
yas