Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

Status: Active » Needs review
StatusFileSize
new32.65 KB
yas’s picture

Status: Needs review » Reviewed & tested by the community
Related issues: +#3095569: Composer could not parse version constraint / could not load package (2)

@jigishaddweb

Thank you for adding the test cases. It looks good to me. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

yas’s picture

Status: Reviewed & tested by the community » Needs work

@jigishaddweb

Thank you for adding the test cases. You don't have to do the refactoring of the following code since that is a part of the repeatTestUpdateSnapshot:

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/SnapshotTest.php
@@ -2,6 +2,8 @@
 
-  /**
-   * Create update snapshot test cases.
-   *
-   * @return string[][]
-   *   test cases array.
-   */
-  private function createUpdateSnapshotTestCases(): array {
-    $test_cases = [];
-    $random = $this->random;
-
-    // Only ID.
-    $test_cases[] = ['id' => 'snap-' . $this->getRandomId()];
-
-    // Name and ID.
-    $test_cases[] = [
-      'name' => 'Snapshot Name ' . $random->name(32, TRUE),
-      'id' => 'snap-' . $this->getRandomId(),
-    ];
-
-    return $test_cases;
-  }
jigish.addweb’s picture

Status: Needs work » Needs review
StatusFileSize
new31.64 KB
new2.56 KB

@yas

Thank you for testing the patch.

I changed the code as per your previous comment.

Please review new patch.

Thanks

yas’s picture

Status: Needs review » Needs work

@jigishaddweb,

I see, now I understood. Then we should put the code into AwsCloudTestFormDataTrait, not AwsCloudTestMockTrait.

jigish.addweb’s picture

Status: Needs work » Needs review
StatusFileSize
new32.64 KB
new2.59 KB

@yas

I refactored the code.

Please review the updated patch again.

Thanks

yas’s picture

Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. It looks good to me now. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed accae73 on 8.x-1.x authored by jigish.addweb
    Issue #3129542 by jigish.addweb, yas: Add test case for OpenStack...

  • yas committed 5efb1e0 on 8.x-2.x authored by jigish.addweb
    Issue #3129542 by jigish.addweb, yas: Add test case for OpenStack...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.