CommentFileSizeAuthor
#2 workflow_buttons-drupal_9_readiness-3129237-2.patch409 bytesunrealauk

Comments

unrealauk created an issue. See original summary.

unrealauk’s picture

unrealauk commented
Assigned: unrealauk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new workflow_buttons-drupal_9_readiness-3129237-2.patch409 bytes
mlncn’s picture

mlncn commented

Thanks, i thought this was already pretty ready for 9! Should the core: part be dropped?

And you've done an automated upgrade_status/drupal-check scan also?

mlncn’s picture

mlncn commented

Update: core: stays because it's needed for compatibility below 8.8, and we're compatible with 8.4 and up.

(Per https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-... )

mlncn’s picture

mlncn commented
Status: Needs review » Reviewed & tested by the community

This was also listed:

Check manually web/modules/contrib/workflow_buttons/tests/src/Functional/ModerationFormTest.php Class Drupal\Tests\content_moderation\Functional\ModerationStateTestBase not found and could not be autoloaded.
Check manually web/modules/contrib/workflow_buttons/tests/src/Functional/ModerationFormTest.php 13 Class Drupal\Tests\content_moderation\Functional\ModerationStateTestBase not found and could not be autoloaded.
Check manually web/modules/contrib/workflow_buttons/tests/src/Functional/NodeFormButtonsTest.php Class Drupal\Tests\node\Functional\NodeTestBase not found and could not be autoloaded.
Check manually web/modules/contrib/workflow_buttons/tests/src/Functional/NodeFormButtonsTest.php 13 Class Drupal\Tests\node\Functional\NodeTestBase not found and could not be autoloaded.

But are possibly false positives— but the testing for this module needs work in general i think.

  • mlncn committed 06526d5 on 8.x-1.x authored by unrealauk 
    Issue #3129237 by unrealauk, mlncn: Drupal 9 readiness
mlncn’s picture

mlncn commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.