Problem/Motivation

Noticed some dsm and strange whitespace committed in the last commit #3046490: Can't SUM in Views

Proposed resolution

Run this to get the standards up to snuff.
phpcbf --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3128775-10.patch2.38 KBjoelpittet
#9 3128775-9.patch3.16 KBjoelpittet
#8 3128775-8.patch3.64 KBjoelpittet
#4 3128775-4.patch4.02 KBjoelpittet
#2 3128775-2.patch4.12 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 3128775-2.patch4.12 KB

Here's the relevant cleanup from that command.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Coding Standards from PHPCS » Coding Standards from PHPCS and commented dsm() left in code

Title change to include the dsm() removal

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3128775-4.patch4.02 KB

Sorry for the self-RTBC but this is trivial and a reroll for the removed dsm() in a recent commit.

ram4nd’s picture

ram4nd commented
Status: Reviewed & tested by the community » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Fair enough😉 the patch has an info file change that won’t apply

ram4nd’s picture

ram4nd commented

The patch should apply. Maybe you can fix it?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 3128775-8.patch3.64 KB

@ram4nd, totally here's the same patch with the correct relative paths (git diff --relative)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 3128775-9.patch3.16 KB

Oh and remove info file changes.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 3128775-10.patch2.38 KB

Feels like my first rodeo here, lol. Upstream changed since I created this patch, rerolled.

  • ram4nd committed 0432cfa on 7.x-1.x authored by joelpittet 
    Issue #3128775 by joelpittet: Coding Standards from PHPCS and commented...
ram4nd’s picture

ram4nd commented
Status: Needs review » Fixed
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Thanks and sorry again for the noisy issue

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.