Problem/Motivation

When an administrator updates the 'Message for blocked YouTube media', this change is not immediately reflected on the page. Only after a cache rebuild, the change appears.

Proposed resolution

Implement a cache dependency on thecookie_content_blocker_media.settings in the cookie_content_blocker_oembed field formatter, so a change in the message invalidates the rendered media-item.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

When an administrator updates the 'Message for blocked YouTube media', this change is immediately reflected on the page.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3128531-2.patch598 bytesidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 3128531-2.patch598 bytes

Attached patch adds a cache dependency on thecookie_content_blocker_media.settings in the cookie_content_blocker_oembed field formatter, so a change in the message invalidates the rendered media-item.

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
commented
Category: Task » Bug report

Thanks, looks legit. Need to test.

  • Steven Buteneers committed 4adcadd on 8.x-1.x 
    Issue #3128531 by idebr: Changing the 'Message for blocked media' does...
steven buteneers’s picture

steven buteneers commented
Status: Needs review » Fixed

Reviewed & tested. It works!
Thanks for the contribution ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.