Great module!!

Is it possible for it to also work with views for custom entities that are made with ECK https://www.drupal.org/project/eck ? Currently the filter doesn't appear for these views.

CommentFileSizeAuthor
#4 3128500-work-with-eck-other-entities-4.patch1.03 KBsolide-echt

Comments

studio-days created an issue. See original summary.

solide-echt’s picture

solide-echt commented

Thnx.
The dev version should work with any entity type, not just nodes. I haven't tried ECK explicitly, just tested on a custom entity I needed for a project.

If you can confirm that's working I'll make a 1.0 release.

Eric

studio-days’s picture

studio-days commented

Sorry to report that it's not working with an ECK entity with dev version either...

solide-echt’s picture

solide-echt commented
StatusFileSize
new 3128500-work-with-eck-other-entities-4.patch1.03 KB

Thanks for testing. In the module file there was still a limitation to nodes. Please find attached a patch. Tested with ECK and works fine for me now.

studio-days’s picture

studio-days commented

Thanks again BUT I'm getting an error when trying to install this patch:

  - Installing drupal/delta_filter (dev-1.x 4551aa1): Cloning 4551aa1cb4 from cache
  - Applying patches for drupal/delta_filter
    https://www.drupal.org/files/issues/2020-04-27/3128500-work-with-eck-other-entities-4.patch (3128500: Work with an ECK Entity view)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-04-27/3128500-work-with-eck-other-entities-4.patch

Same as when I try with 1.0.0-rc1

solide-echt’s picture

solide-echt commented

Hi,

Sorry to hear that - and it's been a bit of a delay. Commit 4551aa1 is not the latest commit, that should have been bbd07cc. It looks as if you didn't change branches and got the latest commit for rc1 for which the patch doesn't apply. Maybe the confusion is due to commit 4551aa1 being applied to both dev and rc1 branch, I was confused about branches and tags a bit.

Eric

solide-echt’s picture

solide-echt commented
Status: Active » Fixed

Released 8.1.0 today in which custom entities should work. Thank you for your patience.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.