Drupal 7 MySQL 8 test runner needs a new version of drush 8.x

If there is a new Drush patch (semver speaking) release with the fixes, would CI pick that version, assuming semver is used?

Drush 8.3.3 contains the fixes needed so that Drush will run with MySql 8.

I changed the status to critical because it is - MySql 8 totally disables a Drupal 7 site, and we don't have a fix yet. It's hard to get a fix approved and committed when we can't test the fix with the testbot. And in the next few months we're going to see a huge spike in people upgrading their os/distribution and having to deal with MySql 8, so this needs to be fixed as soon as possible.

Okay, so we currently have https://git.drupalcode.org/project/drupalci_environments/-/blob/producti...

The only place drush is used in the containers is to set everything up before testing for d7.

The only real option here is to upgrade drush completely, for all containers, for all d7 testing.

Would that have any adverse effects?

Okay, I ran a test locally, and am able to get the patch in https://www.drupal.org/project/drupal/issues/2978575 to apply and test against mysql 8.

I will slot this into my sprint to upgrade soon, but it takes a while to rebuild and test all the containers that will be affected. In the meantime, a patch can upgrade drush as demonstrated in this comment:

https://www.drupal.org/project/drupal/issues/2978575#comment-13704932

@joseph.olstad: What Mixologic did was to add a drupalci.yml to the patch in #2978575-118: Mysql 8 Support on Drupal 7.

That drupalci.yml instructs the testbot to download drush 8.3.5 (the latest) and use it to build the test environment for that specific patch, and only for that patch. This allows us to immediately run the tests we need without having to immediately update DrupalCI.

Think of this as test-driving the new version of drush in the DrupalCI environment. IF the new version of drush doesn't cause problems THEN DrupalCI can upgrade drush for all D7 tests, but this is something that needs to be seen first so that this drush upgrade is not disruptive.

I think this is a good strategy - we can now test D7/MySql 8 and make progress on #2978575: Mysql 8 Support on Drupal 7 - all we have to do it keep including that drupalci.yml in our patches. Likewise, @mixologic can upgrade the testbot on his schedule after he's sure it will not cause problems - after all, he's the one who will have to fix any problems caused by this change.

I rebuilt the containers yesterday, and they all now have drush 8.3.5.