Theme Olivero's language switcher

I've honestly never done a multilingual site. Is this something that's in core? How do other themes handle this?

Hmmm, nice catch @DuneBL i believe we really can theme it. I don't know honestly who use core language switcher block, but i'm ok to have at least minimal styles for it.

@mherchel basically all you have to do, is to:
1. Enable Language core module
2. Add any language here /admin/config/regional/language
3. Add Language switcher block in any region here /admin/structure/block/list/olivero

Basically it is just a list of links:

Umami has an open issue for #3042417: Accessible dropdown for Umami's language-switcher and mobile main-menu

Adding @jwitkowski79 as the assignee of this issue as this work is blocked until we have a design in place to reference.

We just ran into this issue - currently there is only room for 3 languages :-) It does not look great but it works.

Uh... this is the wrong screenshot - correct one posted further down below 👇

I have attached a patch and after patch screenshot. Taking Bartik's design for reference.

Sorry - that screenshot I posted earlier was not the correct one!

This is what Olivero looks like right now - before any changes:

Applied #12 patch working fine sharing the screenshot

Applied patch #12 and it's removing language switcher dots. Please review the screenshots.

Patch #12 applied cleanly and it is working well.

Before patch:

After patch:

Well, i guess solution from 12th patch is a bit wrong, because it disables side margins and set `list-style: none;` to all `ul.links` selectors. This task is about language switcher links only, so i reworked 12th patch with BEM and new drupal library.

Verified and applied patch #21.
The patch is getting Failed

Please see attached screenshots.
Moving to Needs Work.

@chetanbharambe, Patch is passing Drupal CI. so no chances of failing. Please update your local setup.

The most correct way of checking the patch is working or not, add a retest for the targeted branch.

This patch ( #21 ) applied cleanly for me and the results are also expected.
When looking into language switcher, it is looking good now in listing form.
Adding screenshot of new language switcher UI.

Patch #21 applied successfully and working as expected.

Tested on 9.3.x-dev with Chrome (Version 90.0.4430.212 (Official Build))
Testing steps followed for the issue verification

Status: Reviewed & tested by Community

Testing Steps:
1. Enable Language core module
2. Add any language here /admin/config/regional/language
3. Add Language switcher block in any region here /admin/structure/block/list/olivero
4. Create a Content type
5. Verify the Language switcher on top
6. Apply the patch and clear the cache
7. Verify the UI changes

Note: In this process I faced issue on applying patch 3127588-21.patch .. So I applied the patch lang-3127588-13.patch and tested the fix.

I discussed this with @mherchel earlier, the maintainer of Olivero who said that he was going to enlist their designer to help with that, and create an issue. He asked me to hold off a bit so he can give the issue some attention shortly. Setting back to needs review and tagging for subsystem maintainer review.

Thanks @alexpott. I'm going to postpone this for now until we figure out a design in #3221381: Design and placement for language switcher

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.

Olivero will be moved to a contributed project before Drupal 12.0.0 is released.

Olivero is now in contrib