Comments

DuneBL created an issue. See original summary.

mherchel’s picture

I've honestly never done a multilingual site. Is this something that's in core? How do other themes handle this?

kostyashupenko’s picture

Hmmm, nice catch @DuneBL i believe we really can theme it. I don't know honestly who use core language switcher block, but i'm ok to have at least minimal styles for it.

@mherchel basically all you have to do, is to:
1. Enable Language core module
2. Add any language here /admin/config/regional/language
3. Add Language switcher block in any region here /admin/structure/block/list/olivero

Basically it is just a list of links:
lang switcher

kostyashupenko’s picture

Issue tags: +Needs design
mherchel’s picture

Title: Is there some plan to theme language switcher? » Theme language switcher?
Version: » 8.x-1.0-alpha3
mherchel’s picture

Title: Theme language switcher? » Theme language switcher
mherchel’s picture

Title: Theme language switcher » Theme Olivero's language switcher
Project: Olivero » Drupal core
Version: 8.x-1.0-alpha3 » 9.1.x-dev
Component: Code » Olivero theme
shaal’s picture

proeung’s picture

Assigned: Unassigned » jwitkowski79

Adding @jwitkowski79 as the assignee of this issue as this work is blocked until we have a design in place to reference.

proeung’s picture

Priority: Normal » Major
karing’s picture

StatusFileSize
new462.36 KB

We just ran into this issue - currently there is only room for 3 languages :-) It does not look great but it works.

Uh... this is the wrong screenshot - correct one posted further down below 👇

gauravvvv’s picture

I have attached a patch and after patch screenshot. Taking Bartik's design for reference.

gauravvvv’s picture

Status: Active » Needs review
karing’s picture

karing’s picture

StatusFileSize
new190.68 KB

Sorry - that screenshot I posted earlier was not the correct one!

This is what Olivero looks like right now - before any changes:

Theme Switcher before

vikashsoni’s picture

StatusFileSize
new5.43 KB
new5.27 KB

Applied #12 patch working fine sharing the screenshot

hinal05’s picture

StatusFileSize
new315.64 KB
new326.91 KB

Applied patch #12 and it's removing language switcher dots. Please review the screenshots.

Madhu kumar’s picture

StatusFileSize
new123.16 KB
new122.99 KB

Patch #12 applied cleanly and it is working well.

Before patch:

before-patch

After patch:

after

Madhu kumar’s picture

Status: Needs review » Reviewed & tested by the community
kostyashupenko’s picture

kostyashupenko’s picture

Assigned: kostyashupenko » Unassigned
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new2.42 KB
new2.85 KB

Well, i guess solution from 12th patch is a bit wrong, because it disables side margins and set `list-style: none;` to all `ul.links` selectors. This task is about language switcher links only, so i reworked 12th patch with BEM and new drupal library.

chetanbharambe’s picture

Status: Needs review » Needs work
StatusFileSize
new439.04 KB
new308.61 KB

Verified and applied patch #21.
The patch is getting Failed

Please see attached screenshots.
Moving to Needs Work.

gauravvvv’s picture

Status: Needs work » Needs review

@chetanbharambe, Patch is passing Drupal CI. so no chances of failing. Please update your local setup.

The most correct way of checking the patch is working or not, add a retest for the targeted branch.

mitthukumawat’s picture

StatusFileSize
new23.47 KB

This patch ( #21 ) applied cleanly for me and the results are also expected.
When looking into language switcher, it is looking good now in listing form.
Adding screenshot of new language switcher UI.

Madhu kumar’s picture

StatusFileSize
new239.09 KB

Patch #21 applied successfully and working as expected.

Agnesh Tank’s picture

Version: 9.1.x-dev » 9.3.x-dev
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new457.3 KB
new497.3 KB
new1.16 KB

Tested on 9.3.x-dev with Chrome (Version 90.0.4430.212 (Official Build))
Testing steps followed for the issue verification

Status: Reviewed & tested by Community

Testing Steps:
1. Enable Language core module
2. Add any language here /admin/config/regional/language
3. Add Language switcher block in any region here /admin/structure/block/list/olivero
4. Create a Content type
5. Verify the Language switcher on top
6. Apply the patch and clear the cache
7. Verify the UI changes

Note: In this process I faced issue on applying patch 3127588-21.patch .. So I applied the patch lang-3127588-13.patch and tested the fix.

alexpott’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs subsystem maintainer review

I discussed this with @mherchel earlier, the maintainer of Olivero who said that he was going to enlist their designer to help with that, and create an issue. He asked me to hold off a bit so he can give the issue some attention shortly. Setting back to needs review and tagging for subsystem maintainer review.

mherchel’s picture

Status: Needs review » Postponed

Thanks @alexpott. I'm going to postpone this for now until we figure out a design in #3221381: Design and placement for Olivero's language switcher

mherchel’s picture

Priority: Major » Normal
mherchel’s picture

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.