Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Developer experience
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Apr 2020 at 14:52 UTC
Updated:
30 Apr 2020 at 08:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jsacksick commentedAlso,
removeItem()callsrecalculateTotalPrice()which means if 5 items are removed by the availability order processor, the order total will be recalculated 5 times, so besides fixing eventual errors, that patch should also improve performance when more than one item is removed because it's unavailable.Weirdly, it seems we don't have any test for the availability order processor, so we might have to add that too.
Comment #3
jsacksick commentedComment #4
jsacksick commentedComment #7
jsacksick commentedComment #9
jsacksick commentedComment #10
jsacksick commentedComment #12
jsacksick commentedCommitted a slightly different patch, and it turns out we already have tests coverage, so didn't add any.