Social Auth Dribbble allows users to register and login to a Drupal site with their Dribbble account. It is based on Social Auth and Social API. This module adds a path user/login/dribbble which redirects the user to Dribbble for authentication.

Installation guide

https://www.drupal.org/docs/8/modules/social-api/social-api-2x/social-au...

Project link

https://www.drupal.org/project/social_auth_dribbble

Git instructions

git clone --branch 8.x-2.x https://git.drupalcode.org/project/social_auth_dribbble.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-social_auth_dr...

Comments

neel24 created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Thank you for applying! I added the PAReview checklist link. Reviewers will check the project, and report what should be changed.

PAReview just reports the READme.txt file has lines that are longer than 80 characters.

rksyravi’s picture

rksyravi
Primary language Hindi
Location New Delhi, 🇮🇳
commented
Status: Needs review » Needs work

Hi @neel24,

Thank you for contribution!!!

Below are some issues that need to fixed.

Line   src/Controller/DribbbleAuthController.php                                                                            
 ------ -------------------------------------------------                                                           
  80     PHPDoc tag @var for variable $profile contains unknown class CrewLabs\OAuth2\Client\Provider\DribbbleResourceOwner.  
  86     Call to method getId() on an unknown class CrewLabs\OAuth2\Client\Provider\DribbbleResourceOwner.                    
  88     Call to method getName() on an unknown class CrewLabs\OAuth2\Client\Provider\DribbbleResourceOwner.                  
  90     Call to method getId() on an unknown class CrewLabs\OAuth2\Client\Provider\DribbbleResourceOwner.                    
  92     Call to method getAvatarUrl() on an unknown class CrewLabs\OAuth2\Client\Provider\DribbbleResourceOwner.             
 ------ ---------------------------------------------------------------------------------------------- 
  Line   src/DribbbleAuthManager.php                                                                                         
 ------ ------------------------------------------------------- 
  43     Caught class League\OAuth2\Client\Provider\Exception\IdentityProviderException not found.                           
  45     Call to method getMessage() on an unknown class League\OAuth2\Client\Provider\Exception\IdentityProviderException.  
  92     Caught class League\OAuth2\Client\Provider\Exception\IdentityProviderException not found.                           
  94     Call to method getMessage() on an unknown class League\OAuth2\Client\Provider\Exception\IdentityProviderException.  
 ------ --------------------------------------------
  Line   src/Plugin/Network/DribbbleAuth.php                                                                                                                      
 ------ ------------------------------------
  39     Return typehint of method Drupal\social_auth_dribbble\Plugin\Network\DribbbleAuth::initSdk() has invalid type CrewLabs\OAuth2\Client\Provider\Dribbble.  
  64     Instantiated class CrewLabs\OAuth2\Client\Provider\Dribbble not found.
shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented

Hi @rksyravi, @neel24

I have seen only in the README.txt file warning below. 

FILE: ...ork/drupal-8/web/modules/contrib/social_auth_dribbble/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 69 | WARNING | Line exceeds 80 characters; contains 82 characters
 70 | WARNING | Line exceeds 80 characters; contains 84 characters
 71 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------

Time: 636ms; Memory: 8Mb
rohitrajputsahab’s picture

rohitrajputsahab commented

Add core version in *.info.yml file.

core_version_requirement: ^8 || ^9

rohitrajputsahab’s picture

rohitrajputsahab commented

Error: Class 'Drupal\social_auth\Controller\OAuth2ControllerBase' not found in include() (line 18 of /var/www/html/drupal-8.5/modules/social_auth_dribbble/src/Controller/DribbbleAuthController.php)

When I install this module my Drupal 8 setup showing error. Please fix this.

neel24’s picture

neel24 commented

Hi @rohit-rajput-sahab, this module requires these 2 modules to work: Social Auth and Social API. Have a look at the installation guide as well: https://www.drupal.org/docs/8/modules/social-api/social-api-2x/social-au...

neel24’s picture

neel24 commented
Status: Needs work » Needs review

Hi @rksyravi, could you let me know where you got the error messages from because PAReview only found some warnings from the readme which have now been fixed. Updated PAReview result: https://pareview.sh/pareview/https-git.drupal.org-project-social_auth_dribbble.git

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

It seems the errors reported in comment #3 are given from a tool that isn't able to handle the module dependencies. The composer.json file contains the module dependencies, including bymayo/oauth2-dribbble.

neel24’s picture

neel24 commented

Ah ok, I guess that the tests from #3 might have been run with only Social Auth Dribbble installed. In addition to the dependencies, Social Auth and Social API need to be installed as well. There is an installation guide as well which can be found here: https://www.drupal.org/docs/8/modules/social-api/social-api-2x/social-au...

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Fixed

DribbbleAuthManager: "->error('There was an error during authentication. Exception: ' . $e->getMessage());" do not concatenate variables into log messages, use placeholders with the second parameter instead. See https://drupalize.me/blog/201510/how-log-messages-drupal-8 . Please check all your error() log calls.

Otherwise looks good to me.

Thanks for your contribution, Neel!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.