New DB URI breaks if an existing query part is missing the new module parameter.

I would like to use the database uri sqlsrv://sa:Password12!@localhost/mydrupalsite?schema=dbo

The new feature assumes that if there is any parameter in the query position, it must include ‘?module=something’. Changing if ($query['module']) to if (isset($query['module'])). Will allow a driver to specify a query parameter without a ‘module’.

Without my proposed change, my example URI will cause an error to be thrown because $query[‘module’] is not set. I can add an override to Connection:: createConnectionOptionsFromUrl() to ensure my module’s custom functionality is correct. Core does not need to know anything about what custom query parameters the sqlsrv module is implementing...but the lack of the isset($query[‘module’]) prevents sqlsrv (and any other driver) from implementing query parameters.

Good point on the empty string part. We could use short circuiting and do if(isset($query[‘module’]) && $query[‘module’]).

The first rule of PHP is to check user input. Core is not checking the query array and instead assuming that if it exists, there must be a ‘module’ index. I would like it to silently ignore cases where this index does not exist instead of throwing an error.

I added a few more details to the issue. Should it be a bug instead of a feature request?

Should I add this to core/tests/Drupal/Tests/Core/Database/UrlConversionTest.php

'MySql with a custom query parameter' => [
        '',
        'mysql://test_user:test_pass@test_host:3306/test_database?extra=value',
        [
          'driver' => 'mysql',
          'username' => 'test_user',
          'password' => 'test_pass',
          'host' => 'test_host',
          'database' => 'test_database',
          'port' => 3306,
          'namespace' => 'Drupal\Core\Database\Driver\mysql',
        ],
      ],

This would test that adding some value to the query parameter will have no effect on the connection array; they will be silently ignored.

including a failing test and a patch for the failure.

Testing demonstrated the failure and the fix. Needs review.