After upgrading loadCSS to version 2.1.0 AdvAgg fails to recognise its existence. This is caused by the code in advagg_mod_libraries_info that looks for the version strings in package.json, but the search is limited to the first 10 lines only. In 2.1.0 the version string is on line 56. Increasing the value of lines on line 1181 of advagg_mod.module to anything larger works. I will supply a patch shortly.

CommentFileSizeAuthor
#3 advagg-3126417-1-fails-to-recognise-loadcss-210.patch481 bytesRafal Lukawiecki

Comments

Rafal Lukawiecki created an issue. See original summary.

Rafal Lukawiecki’s picture

Rafal Lukawiecki
Primary language English
Location Ireland
commented
Issue summary: View changes
Rafal Lukawiecki’s picture

Rafal Lukawiecki
Primary language English
Location Ireland
commented
StatusFileSize
new advagg-3126417-1-fails-to-recognise-loadcss-210.patch481 bytes

Patches the code checking for presence of loadCSS to look 100 lines into its package.json for the version string.

Rafal Lukawiecki’s picture

Rafal Lukawiecki
Primary language English
Location Ireland
commented
Status: Active » Needs review
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!
Thanks for you job @Rafal Lukawiecki!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed
Rafal Lukawiecki’s picture

Rafal Lukawiecki
Primary language English
Location Ireland
commented

Thank you, @thalles, for maintaining this module and committing the little fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.