Problem/Motivation
See #2501901: Allow configuring the environment via an environment variable
For update.php we can use the same kernel which used in index.php
Proposed resolution
Replace UpdateKernel with DrupalKernel.
Remaining tasks
TBD;
User interface changes
no changes
API changes
Deprecate UpdateKernel
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3126222-nr-bot.txt | 143 bytes | needs-review-queue-bot |
| #2 | 3126222-2.patch | 11.29 KB | voleger |
Comments
Comment #2
volegerFirst iteration. With that change I successfully performed update script for 8.8.x to 9.1.x database update.
Set 'needs review' to receive some feedback on which task left to introduce 'update' environment in core.
Comment #3
joachim commentedI'm not sure this sort of change makes code more readable or more maintainable.
Currently, UpdateKernel inherits from DrupalKernel:
In cacheDrupalContainer(), UpdateKernel overrides the method completely.
In initializeContainer(), UpdateKernel sets the property before calling the parent.
To me, these seems like things that OO inheritance is good for.
Comment #9
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #11
andypostComment #12
voleger