MTCaptcha is an efficient security solution to protect your Drupal website forms against spam comments and brute-force attacks. It can be integrated with the comments, login, registration, forgot password, etc

Project link

https://www.drupal.org/project/mtcaptcha

Git instructions

git clone --branch 7.x-1.x https://git.drupalcode.org/project/mtcaptcha.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-mtcaptcha.git

CommentFileSizeAuthor
#15 3125996_15.patch70 bytesvenugopp
#13 3125996.patch70 bytesvenugopp

Comments

mtcaptcha created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes

Thank you for applying! I added the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

avpaderno’s picture

Issue summary: View changes
Status: Needs review » Needs work

The branch name (7.x) is wrong. A correct branch name would be 7.x-1.x. You need to create the correct branch, make it the default one, and then delete the wrong branch.

avpaderno’s picture

Also, the module files should not be in the mtcaptcha/mtcaptcha directory, but directly in the repository root directory.

The license file needs to be removed, as Drupal modules, themes, installation profiles, and distributions hosted on drupal.org are licensed under the same license used from Drupal, which isn't Apache License version 2.
Agreeing to the Git access agreement, you agreed also to the following:

I will only commit code licensed as GPL-2.0+ and non-code assets licensed with GPL friendly licenses to Drupal project repositories.

mtcaptcha’s picture

Issue summary: View changes
mtcaptcha’s picture

Status: Needs work » Needs review

Thank you for your suggestions!!

Deleted a tag named 7.x
Created a branch called 7.x-2.0. However, I am unable to make it as default branch as I am belongs to developer role. Could you help me here?
Removed the license and changed the module files and committed again.
Please review

avpaderno’s picture

A correct branch name is 7.x-1.x or 7.x-2.x, not 7.x-2.0, which is a tag name. The x in 7.x-1.x doesn't mean replace it with any number.

avpaderno’s picture

Status: Needs review » Needs work
avpaderno’s picture

The default branch is set in https://www.drupal.org/node/3124085/edit/default-branch. Before a branch can be deleted, the correct branch must be created and made the default one; without changing the default branch, a branch cannot be deleted.

mtcaptcha’s picture

Issue summary: View changes
mtcaptcha’s picture

Thank you!!.
I have created a branch called 7.x-1.x and made it as default branch. Please continue to test!

mtcaptcha’s picture

Status: Needs work » Needs review
venugopp’s picture

StatusFileSize
new70 bytes

Here is the patch with the PHPCS fixes required for the PAReview & Coding standards issues.

mtcaptcha’s picture

Thank You @venugopp. I have committed the patch file in the provided branch. Please take a look at it

venugopp’s picture

StatusFileSize
new70 bytes

One other issue is still pending. Here is the patch for the pending item.
https://pareview.sh/pareview/https-git.drupal.org-project-mtcaptcha.git-...

Note: Using the commit command from the ticket, so that you give credits to the author.

avpaderno’s picture

The task of reviewers is pointing out what needs to be changed, not providing patches.

avpaderno’s picture

Issue summary: View changes
mtcaptcha’s picture

Fixed the issue @Team.
Please proceed further.

shaktik’s picture

Thank you for the contribution!

Review of the 7.x-1.x branch (commit 7c6b620): It looks good to me.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.