Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
8 Apr 2020 at 12:07 UTC
Updated:
8 May 2020 at 20:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
avpadernoThank you for applying! I added the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.
If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.
Comment #3
avpadernoThe branch name (7.x) is wrong. A correct branch name would be 7.x-1.x. You need to create the correct branch, make it the default one, and then delete the wrong branch.
Comment #4
avpadernoAlso, the module files should not be in the mtcaptcha/mtcaptcha directory, but directly in the repository root directory.
The license file needs to be removed, as Drupal modules, themes, installation profiles, and distributions hosted on drupal.org are licensed under the same license used from Drupal, which isn't Apache License version 2.
Agreeing to the Git access agreement, you agreed also to the following:
Comment #5
mtcaptcha commentedComment #6
mtcaptcha commentedThank you for your suggestions!!
Deleted a tag named 7.x
Created a branch called 7.x-2.0. However, I am unable to make it as default branch as I am belongs to developer role. Could you help me here?
Removed the license and changed the module files and committed again.
Please review
Comment #7
avpadernoA correct branch name is 7.x-1.x or 7.x-2.x, not 7.x-2.0, which is a tag name. The x in 7.x-1.x doesn't mean replace it with any number.
Comment #8
avpadernoComment #9
avpadernoThe default branch is set in https://www.drupal.org/node/3124085/edit/default-branch. Before a branch can be deleted, the correct branch must be created and made the default one; without changing the default branch, a branch cannot be deleted.
Comment #10
mtcaptcha commentedComment #11
mtcaptcha commentedThank you!!.
I have created a branch called 7.x-1.x and made it as default branch. Please continue to test!
Comment #12
mtcaptcha commentedComment #13
venugopp commentedHere is the patch with the PHPCS fixes required for the PAReview & Coding standards issues.
Comment #14
mtcaptcha commentedThank You @venugopp. I have committed the patch file in the provided branch. Please take a look at it
Comment #15
venugopp commentedOne other issue is still pending. Here is the patch for the pending item.
https://pareview.sh/pareview/https-git.drupal.org-project-mtcaptcha.git-...
Note: Using the commit command from the ticket, so that you give credits to the author.
Comment #16
avpadernoThe task of reviewers is pointing out what needs to be changed, not providing patches.
Comment #17
avpadernoComment #18
mtcaptcha commentedFixed the issue @Team.
Please proceed further.
Comment #19
shaktikThank you for the contribution!
Review of the 7.x-1.x branch (commit 7c6b620): It looks good to me.
Comment #20
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.