See #2066993-57: Use magic methods to sync container property to \Drupal::getContainer in functional tests: Apparently, it is a bad idea to use $this->container in Functional tests.
We have a few instances of that in our code base which we should therefore probably get rid off:

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php
tests/src/Functional/CacheabilityTest.php
tests/src/Functional/SearchApiBrowserTestBase.php
tests/src/Functional/ViewsTest.php
CommentFileSizeAuthor
#4 search-api-3125444-4.patch2.02 KBrajesh kairamkonda

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: +Novice

Since all we need to do (probably) is replace all those instances with \Drupal::getContainer(), this is definitely Novice level stuff.

rajesh kairamkonda’s picture

rajesh kairamkonda commented
Assigned: Unassigned » rajesh kairamkonda
rajesh kairamkonda’s picture

rajesh kairamkonda commented
StatusFileSize
new search-api-3125444-4.patch2.02 KB
rajesh kairamkonda’s picture

rajesh kairamkonda commented
Status: Active » Needs review
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Looks great, thanks!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.