This patch fixes the following issues:

- #weight override on "autoclose" element
- inconsistent t() calls (global vs class)
- unused variables

CommentFileSizeAuthor
#6 bootstrap_datepicker-element-weight-override-inconsistent-t-calls-fixes-3125029-2.patch11.98 KBborutpiletic
#2 bootstrap_datepicker-element-weight-override-inconsistent-t-calls-fixes-3125029.patch12.29 KBborutpiletic

Comments

borutpiletic created an issue. See original summary.

borutpiletic’s picture

borutpiletic commented
Title: Inconsistent translation t calls » Element weight override and inconsistent t calls fixes
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new bootstrap_datepicker-element-weight-override-inconsistent-t-calls-fixes-3125029.patch12.29 KB

Status: Needs review » Needs work

The last submitted patch, 2: bootstrap_datepicker-element-weight-override-inconsistent-t-calls-fixes-3125029.patch, failed testing. View results

borutpiletic’s picture

borutpiletic commented
Status: Needs work » Needs review
martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Needs review » Needs work 
@@ -494,8 +493,6 @@ abstract class BootstrapDatepickerBase extends DateTimeWidgetBase implements Con
    */
   public function settingsSummary() {
     // Default settings.
-    $default_settings = BootstrapDatepickerBase::defaultSettings();
-
     $today_options = [
       'FALSE' => $this->t('No'),
       'TRUE' => $this->t('Yes'),

I think we should keep this.

The rest of the changes seem logical.

borutpiletic’s picture

borutpiletic commented
StatusFileSize
new bootstrap_datepicker-element-weight-override-inconsistent-t-calls-fixes-3125029-2.patch11.98 KB

Variable was removed since it is never used. It was added back in the attached patch.

borutpiletic’s picture

borutpiletic commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: bootstrap_datepicker-element-weight-override-inconsistent-t-calls-fixes-3125029-2.patch, failed testing. View results

borutpiletic’s picture

borutpiletic commented
Status: Needs work » Needs review
martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Needs review » Reviewed & tested by the community

  • Martijn de Wit committed 59d5731 on 8.x-1.x 
    Issue #3125029 by borutpiletic, Martijn de Wit: Element weight override...
martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.