Front Page 8.x-1.0-beta1+2-dev
Scanned on Sat, 04/04/2020 - 13:38.

2 errors found. 2 warnings found. Items categorized "Fix now" are uses of
deprecated APIs from community unsupported core versions.

front/front_page.module:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 183  │ Call to deprecated function drupal_render_children().        │
│         │      │ Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. │
│         │      │ Avoid early rendering when possible or loop through the      │
│         │      │ elements and render them as they are available.              │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

front/src/EventSubscriber/FrontPageSubscriber.php:
┌────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │                           MESSAGE                            │
├────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix    │ 29   │ Call to deprecated function drupal_installation_attempted(). │
│ later  │      │ Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. │
│        │      │ Use                                                          │
│        │      │ \Drupal\Core\Installer\InstallerKernel::installationAttempte │
│        │      │ d() instead.                                                 │
│        │      │                                                              │
└────────┴──────┴──────────────────────────────────────────────────────────────┘

front/src/Form/FrontPageArrangeForm.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 48   │ Call to deprecated method l() of class Drupal. Deprecated in │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Use           │
│         │      │ \Drupal\Core\Link::fromTextAndUrl() instead.                 │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

front/front_page.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                        MESSAGE                         │
├──────────┼──────┼────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add <code>core_version_requirement: ^8 || ^9

to │
│ manually │ │ front_page.info.yml to designate that the module is │
│ │ │ compatible with Drupal 9. See │
│ │ │ https://www.drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴────────────────────────────────────────────────────────┘

CommentFileSizeAuthor
#4 interdiff_2-4.txt557 bytesbunty badgujar
#4 front-3124993-4.patch1.79 KBbunty badgujar
#2 front-3124993-2.patch1.82 KBkarishmaamin

Comments

wolfhowling created an issue. See original summary.

karishmaamin’s picture

karishmaamin commented
Status: Active » Needs review
StatusFileSize
new front-3124993-2.patch1.82 KB

please review

shamsher_alam’s picture

shamsher_alam commented
Status: Needs review » Reviewed & tested by the community

I have check for D9 and it working

bunty badgujar’s picture

bunty badgujar commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs issue summary update
StatusFileSize
new front-3124993-4.patch1.79 KB
new interdiff_2-4.txt557 bytes 
   ];
   $output .= $renderer->render($front_page_arrange);
-  $output .= drupal_render_children($form);
-
+        foreach (Element::children($form) as $key) {
+            if (!empty($form[$key])) {
+                $output .= \Drupal::service('renderer')->render($form[$key]);
+             }
+      }

Tabs are not correct in above code.

Also, Needs issue summary update as following file is removed from current branch :- front/src/Form/FrontPageArrangeForm.php

oleksandr senenko’s picture

oleksandr senenko commented

Thank you, committed.

oleksandr senenko’s picture

oleksandr senenko commented
Version: 8.x-1.x-dev » 9.1.x-dev
Status: Needs review » Fixed
oleksandr senenko’s picture

oleksandr senenko commented
Status: Fixed » Closed (fixed)