There is a composer.json change that should be made to add the Drupal 9 support badge to the module's main page, as explained here: https://www.drupal.org/project/auto_entitylabel/issues/3111526

EDIT: or perhaps the change needs to be made to the core_version_requirement field in the module's .info file. Here's an example from another project: https://www.drupal.org/files/issues/2020-03-12/3119389-d9-upgrade-2.patch

EDIT 2: see #7

Issue fork imce-3124912

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xeM8VfDh created an issue. See original summary.

xem8vfdh’s picture

xem8vfdh commented
Issue summary: View changes
salah1’s picture

salah1
Location VA, U.S
commented
Assigned: Unassigned » salah1

Will work on this..

salah1’s picture

salah1
Location VA, U.S
commented

I looked at the info file and it has the needed code so nothing else to do here.

name: Imce File Manager
type: module
description: Provides a file manager supporting personal folders.
package: Media
core: 8.x
core_version_requirement: ^8 || ^9
configure: imce.admin
dependencies:
  - 'drupal:system (>= 8.5)'
  - ctools:ctools
  - token:token
salah1’s picture

salah1
Location VA, U.S
commented
Assigned: salah1 » Unassigned
Status: Active » Needs review
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

@xeM8VfDh I am waiting a new release to change D9 module status, I has no pemission to do releases

xem8vfdh’s picture

xem8vfdh commented

@salah1, I think I was wrong about the composer and info changes. Apparently there is some switch a module maintainer can flip somewhere that marks their module as being D9 compatible, and show the aforementioned badge. I am not sure where that switch is, since I'm not a maintainer. Sorry.

@thalles, I'm sorry, I don't understand. Can I help in some way?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

I am IMCE mantainer, but I has no permisson to release a new version, and this badge only should after a new release

xem8vfdh’s picture

xem8vfdh commented
Issue summary: View changes
xem8vfdh’s picture

xem8vfdh commented

hey @thalles, thanks for the clarification. I don't know any of the other maintainers. If you have their contact info maybe you could reach out to them and ask for permission to publish releases, or maybe ask them to take care of it? I appreciate your help, and I am sorry I can't be more helpful :(

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

You can see the mantainers of a module acessando: https://www.drupal.org/project/{project_name}/maintainers.json
On IMCE case https://www.drupal.org/project/imce/maintainers.json

xem8vfdh’s picture

xem8vfdh commented

@thalles, I sent a message to ufku, linking them to your comments here. You can do the same: https://www.drupal.org/user/9910/contact

Looks like ufku might not be very active anymore. I am not sure what else I can do.

ufku’s picture

ufku commented

@thalles: We have different version requirements in different files

  1. "drupal/core": "^8.7 || ^9" in composer.json
  2. core_version_requirement: ^8 || ^9 in info file
  3. also drupal:system (>= 8.5) in info file

If we require 8.7 i think the core_version_requirement should indicate that. Do we need drupal:system requirement?

After clearing this i'll create a 2.x branch with a beta release

Thank you all for working on this. Sorry for the late response.

xem8vfdh’s picture

xem8vfdh commented

thanks for chiming in @ufku!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

@ufku, it would be good to release version 1.8 with several features that solve some problems in the problem queue.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

@ufku, would have some instant communication channel?
To keep us aligned about IMCE.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The .info file should contain core_version_requirement: ^8.7 || ^9 and drupal:system (>= 8.7), to reflect the same requirements the composer.json file contains. The latter is only necessary if a branch of the module, or a previous version of the module, supported Drupal 8.5 or previous versions, to avoid the module is updated on Drupal 8.5, which isn't supported from the new versions/branches.

core_version_requirement is supported from Drupal 8.7.7 or higher versions. Previous versions don't support it, and users would not get an error telling them they are installing the module in a Drupal version the module doesn't support.

  • ufku committed 5f31b7b on 8.x-1.x 
    Issue #3124912: Updated core requirement and sytem dependency
ufku’s picture

ufku commented
Title: Add drupal 9 support badge » Add drupal 9 support
Status: Needs review » Fixed

Thanks @kiamlaluno
Committed the changes and released 8.x-2.0 as a Drupal 9 comptible version

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
xem8vfdh’s picture

xem8vfdh commented

@ufku and @thalles, will one of you change the configuration that indicates the module as being Drupal 9 compatible?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Done @xeM8VfDh!

xem8vfdh’s picture

xem8vfdh commented

awesome, thanks, I appreciate it!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sumit-k made their first commit to this issue’s fork.