Fix project on Drupal ^8.7 and fix failing tests on 8.x-2.x

This should get EncryptedFieldValueManagerTest passing again.

As far as FieldEncryptCacheTest goes I fear it may be a legitimate failure. In any case I've not been able to figure it out, and would love some help on it :)

I've spent some time trying to figure out why FieldEncryptCacheTest is failing, but I cant figure out why.

Perhaps this is expected behaviour? The testDynamicPageCache is passing which is great.

the node entity type isPersistentlyCacheable returns false, yet \Drupal::cache('entity')->get($cid) does return the test node entity in it.

I have also noticed that when we set the node to be uncacheable it was failing as well, and managed to fix that by saving the node after changing its field storage settings.

Took the liberty of improving the base test class:

1. Since #2692387: Define and use base class for simple tests got in, we can now greatly simplify our base test class by extending EncryptTestBase.
2. Use NodeCreationTrait.
3. Use the EntityTypeManager instead of the deprecated entity manager.

And removing setFieldStorageSettings() from FieldEncryptCacheTest since we have a better version on FieldEncryptTestBase.

PHP Fatal error:  Class 'Drupal\Tests\encrypt\Functional\EncryptTestBase' not found in /var/www/html/modules/contrib/field_encrypt/tests/src/Functional/FieldEncryptTestBase.php on line 14

Meaning we need to pull in Encrypt module for the test bot, so adding it to composer.json as requirement.

Argh wrong patch! Please ignore the files on #5.

multitasking--

Docs for this: https://www.drupal.org/docs/develop/using-composer/managing-dependencies...

Let's see if it works this time...

OK, its not finding the encrypt base class because it needs this patch to be applied, which i had on my machine from working on it yesterday.

#3124749: Convert simpletests to PHPUnit

I'd say lets wait for that to get in before working more on this.

#3124749: Convert simpletests to PHPUnit got in, so this is now unblocked :)

OK its now failing because the base test class is only available on the latest tarball of Encrypt. I believe for tests there is benefit in testing against Encrypt HEAD so we can identify issues before a release is cut, in theory catching bugs before they hit sites.

OK, great to see the tests running now.

About the last failing test, I've come to the conclusion that we should only be testing what the module does, which is altering the entity type definition on field_encrypt_entity_type_alter() to mark them as not cacheable. We're already testing this which should be enough imho:

// Check whether node entities are marked as uncacheable.
$this->entityTypeManager->clearCachedDefinitions();
$definition = $this->entityTypeManager->getDefinition('node');
$this->assertFalse($definition->isPersistentlyCacheable());
$this->assertFalse($definition->isRenderCacheable());
$this->assertFalse($definition->isStaticallyCacheable());

In other words, testing core's caching mechanism is out of scope, so I'm removing that part of the test.

Also removing an unused use statement.

Thanks @vijaycs85 for the review!

Re #14.1:
The reason for that is that since #3124749: Convert simpletests to PHPUnit got in 9 days ago, the EncryptTestBase class we're extending is only available on Encrypt dev until they make a release. I explained this on #11 also noting that there could be benefits of testing against dev, up to the maintainers of course.

Re #14.2:
Not a Unit tests expert here... I added these because otherwise there are failures on testGetEncryptedFieldValue() like:
Trying to configure method "setEncryptedValue" which cannot be configured because it does not exist, has not been specified, is final, or is static If it's not the right fix then please let me know - happy to learn :)

Re #15: 👍

Thanks @suzymasri, great to see we can now just depend on the latest encrypt module release.

I think think this is ready to go :)

Fantastic, thanks so much @alexpott for that!