Closed (fixed)
Project:
Entity Extra Field
Version:
2.1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
30 Mar 2020 at 21:40 UTC
Updated:
31 Mar 2026 at 11:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
le72Same here. Any update or fix?
Comment #3
sergey_gabrielyanComment #4
anybodyRunning the title through t() is no option. Needs work and a clean solution. Seems to be an edge-case?
Comment #5
anybodyOkay after looking into this again I see that @geek-merlin made a valid request here, but the implementation in #3 is totally wrong and different. I'll hide it for that reason.
Adding an option to show the views title or use it as label is valid!
Comment #6
anybodyI guess all useful views settings should be exposed. Guess https://www.drupal.org/project/viewsreference has implementations for that!
Should also then be combined with #3443048: Allow the Views plugin to support defining items per page
Comment #7
anybodyI added the need for a setting (checkbox) to the issue summary. I think that's the most important part. Everything else should be clear enough?
Comment #8
anybodyWould someone like to prepare a MR accordingly? Maybe it's a nice novice task?
Comment #9
anybodyComment #11
grevil commentedThis should do the trick, although we should still discuss this approach.
Comment #13
anybody@grevil: entity_extra_field already uses a twig template, but of course we could put one within for the views renderer.
I'm a bit unsure if the expected behavior here would be to have the views title overriding the entity_extra_field title or if it should be additional. Maybe @thomas.frobieter has an opinion on that?
I think it might make sense to override this label with the views title if the new View Title display option is enabled?
Comment #14
grevil commented@anybody, Ah I see! Thanks!
I already added validation, so that "display_label" and "render_view_title" can't be both enabled, but I agree, additonally the view title should simply override the "label" of the entity extra field. I'll check if that is easily implemented, since the label comes from the entity_extra_field entity and the view title is set in the view plugin definition.
Comment #15
grevil commentedAlright, that should do the trick! Please review!
Comment #16
anybodyNice @grevil! I think that makes sense! I left a final comment, but would be great if the others could already review it also. LGTM
Comment #17
anybodyComment #18
anybodyWorks like a charm @grevil!!! Thank you! Merging!
Please tag a new release with all these highlights :)
Comment #19
grevil commentedComment #20
grevil commentedNice, tests fail as expected, adding missing schema.
Comment #21
grevil commentedEverything green now, please review! (Maybe a bit out of scope but I didn't want to create a seperate issue for this)
Comment #22
anybodyNot a nice mix, but good enough, let's keep it like this!
Thanks again for the many improvements! :)
Comment #24
grevil commentedComment #26
anybodyNext all the tasks in #3578499: Add further options for Entity Extra Field "Views" should be focused.