Replace non-test usages of \Drupal::cache() with IoC injection

We do this for non-test code under this issue.

Per the parent issue, rescoping this to do it for non-test code.

So i have to set this back to NW, sorry for the change in the middle!

+++ b/core/modules/ckeditor/src/Plugin/Editor/CKEditor.php
@@ -84,14 +92,17 @@ class CKEditor extends EditorBase implements ContainerFactoryPluginInterface {
-  public function __construct(array $configuration, $plugin_id, $plugin_definition, CKEditorPluginManager $ckeditor_plugin_manager, ModuleHandlerInterface $module_handler, LanguageManagerInterface $language_manager, RendererInterface $renderer, StateInterface $state) {
+  public function __construct(array $configuration, $plugin_id, $plugin_definition, CKEditorPluginManager $ckeditor_plugin_manager, ModuleHandlerInterface $module_handler, LanguageManagerInterface $language_manager, RendererInterface $renderer, StateInterface $state, CacheBackendInterface $cache) {

Needs Change records. In Drupal 9 this argument needs to be optional. In Drupal 10 we can require it. We need to do something like:

    if ($cache === NULL) {
      @trigger_error('The cache.data service must be passed to ' . __NAMESPACE__ . '\CLASSNAME::__construct(). It was added in drupal:9.1.0 and will be required before drupal:10.0.0. See THE CHANGE RECORD URL', E_USER_DEPRECATED);
      $theme_manager = \Drupal::service('cache.data');
    }

@Hardik_Patel_12, thanks for the patch.

+++ b/core/modules/book/src/BookManager.php
@@ -91,12 +91,16 @@
+      @trigger_error('The cache.data service must be passed to ' . __NAMESPACE__ . '\CLASSNAME::__construct(). It was added in drupal:9.1.0 and will be required before drupal:10.0.0. See https://www.drupal.org/node/3160703', E_USER_DEPRECATED);

CLASSNAME here is just a placeholder for example. it should be replaced with a real one, BookManager in this case.

+++ b/core/modules/ckeditor/src/Plugin/Editor/CKEditor.php
@@ -84,14 +92,17 @@ class CKEditor extends EditorBase implements ContainerFactoryPluginInterface {
+  public function __construct(array $configuration, $plugin_id, $plugin_definition, CKEditorPluginManager $ckeditor_plugin_manager, ModuleHandlerInterface $module_handler, LanguageManagerInterface $language_manager, RendererInterface $renderer, StateInterface $state, CacheBackendInterface $cache) {

Here missing a BC layer which is simliar to #14