We need to port https://git.drupalcode.org/project/simplytest/-/tree/7.x-1.x/modules%2Fs... to 8.x-4.x. One note: it needs to expose the one click demos as a JSON feed for the React form to consume. The one click demo module should be a simple plugin system in 8.x-4.x, not hook based like it is now
We have two subscriber modules to the one click demo API:
https://git.drupalcode.org/project/simplytest/-/tree/7.x-1.x/modules%2Fs...
and
https://git.drupalcode.org/project/simplytest/-/tree/7.x-1.x/modules%2Fs...
Those subscribers also need to be ported as plugin instances. YAML template examples can be found in the simplytest_tugboat module
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | port-simplytest-ocd-3123156-6.patch | 17.2 KB | sumitmadan |
| #3 | port-simplytest-ocd-3123156-3.patch | 15.8 KB | sumitmadan |
Comments
Comment #2
sumitmadan commentedComment #3
sumitmadan commentedHi Adam,
I have converted hooks into plugins and ported the module. I have exposed the OCD plugins info as JSON for react. Two things pending:
1. Consuming the API and displaying the button on the react form.
2. The submission of the form and the backend handling for the same.
Please do let me know if anything needs to change in the patch.
Comment #4
nerdsteinThis is excellent stuff, thank you! The patch is almost there and this is a huge help. I found the following things:
1. "Provides a 'drupal' authentication." = this looks like a copy/paste error.
2. "Umani" => "Umami" - I see there should be some file renames
3. The YML templates, like simplytest-tugbot-config-commerce-yml.html.twig appear to still be using PHP Template. Please see the simplytest_tugboat/templates for some examples that use the Drupal 8 Twig format.
4. The spacing/formatting of the YML files are very strict. I see some of the spacing/indents got lost in the new patch
Comment #5
sumitmadan commentedComment #6
sumitmadan commentedUrgghh.. !! My bad. I didn't notice the purpose of templates and thought it's hardcoded without looking into it. Please review now.
Comment #7
nerdsteinThis looks excellent, thank you again. It's really great work.
Merging this in for our testing.
Comment #9
nerdstein