CommentFileSizeAuthor
#3 3122887-3.patch826 byteshardik_patel_12
#3 interdiff-2-3.txt519 byteshardik_patel_12
#2 3122887-2.patch342 bytessuresh prabhu parkala

Comments

Suresh Prabhu Parkala created an issue. See original summary.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Active » Needs review
StatusFileSize
new 3122887-2.patch342 bytes

Please review!

hardik_patel_12’s picture

hardik_patel_12 commented
Issue tags: +Drupal 9 compatibility, +Drupal 9 porting day, +Drupal 9 readiness
StatusFileSize
new interdiff-2-3.txt519 bytes
new 3122887-3.patch826 bytes

I found following issues when i ran drupal-check

drupal-check -ad modules/contrib/perimeter                       
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------- 
  Line   src/EventSubscriber/PerimeterSubscriber.php                                                            
 ------ ------------------------------------------------------------------------------------------------------- 
  27     Access to an undefined property Drupal\perimeter\EventSubscriber\PerimeterSubscriber::$configFactory.  
  46     Access to an undefined property Drupal\perimeter\EventSubscriber\PerimeterSubscriber::$configFactory.  
 ------ -------------------------------------------------------------------------------------------------------

Added a new patch kindly review.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Drupal 9 readiness
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

RTBC for #3, nice catch!

  • Anybody committed d64aae3 on 2.0.x 
    Issue #3122887 by Hardik_Patel_12, Suresh Prabhu Parkala, Anybody:...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Reviewed & tested by the community » Fixed

Just release 2.0.x version with Drupal 9 compatibility, please help to test with latest Drupal 8 and Drupal 9 so we can later deprecate 1.x.
Thanks a lot all! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.