Add core_version_requirement: ^8 || ^9 to facebook_pixel.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#16 interdiff-3122781-15-16.txt398 bytesfenstrat
#16 3122781-16.patch8.89 KBfenstrat
#15 drupal9-readiness-compatibility-3122781-15.patch8.9 KBchuyenlv
#14 drupal9-readiness-compatibility-3122781-14.patch8.96 KBchuyenlv
#8 3122781-7.patch1.29 KBtushar.verma
#6 3122781-6.patch791 byteskarishmaamin
#2 drupal9-readiness-3122781-2.patch390 bytesmo_farhaz

Issue fork facebook_pixel-3122781

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal9-readiness-3122781-2.patch390 bytes

please review it

shreyal999’s picture

shreyal999 commented
Issue tags: +Drupal 9 compatibility
smrutha’s picture

smrutha commented
Status: Needs review » Reviewed & tested by the community
bwaindwain’s picture

bwaindwain commented
Status: Reviewed & tested by the community » Needs work

When I try patch #2 in Drupal 9.0.5 I get

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "facebook_pixel.facebook_event" has a dependency on a non-existent service "user.private_tempstore". in Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->processValue() (line 86 of /var/www/html/d9fbpixel/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php).

possible as a result of this patch https://www.drupal.org/project/facebook_pixel/issues/2917474#comment-129...

karishmaamin’s picture

karishmaamin commented
Status: Needs work » Needs review
StatusFileSize
new 3122781-6.patch791 bytes

please review

bwaindwain’s picture

bwaindwain commented

I can confirm the module installs without errors in D9.0.5 and seems to run fine. It's still based on 8.x alpha version so...?

Thanks @karishmaamin

tushar.verma’s picture

tushar.verma commented
StatusFileSize
new 3122781-7.patch1.29 KB

tested patch#6 on D8 &9 , info.yml changes needed for the sub module hence Adding core_version_requirement: ^8 || ^9 to designate that the module is compatible with Drupal 8 and 9
So here is the updated patch

devdesagar’s picture

devdesagar commented

Hi Team,
Patch #8 is working fine. Checked on both Drupal 8 and drupal 9

devdesagar’s picture

devdesagar commented
Status: Needs review » Reviewed & tested by the community
tushar.verma’s picture

tushar.verma commented

Just wanted to add that few test cases failed because the sub module is not getting enabled as the dependency in info.yml file is not defined.
When we manually install and enable the required dependency module then the warning issues are resolved.

GaëlG made their first commit to this issue’s fork.

GaëlG opened merge request !1

chuyenlv’s picture

chuyenlv commented
StatusFileSize
new drupal9-readiness-compatibility-3122781-14.patch8.96 KB

I checked and created this patch to fix compatibility and drupal 9 readiness.
please review

chuyenlv’s picture

chuyenlv commented
StatusFileSize
new drupal9-readiness-compatibility-3122781-15.patch8.9 KB

updated patch from #14
please review

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
StatusFileSize
new 3122781-16.patch8.89 KB
new interdiff-3122781-15-16.txt398 bytes

Confirming that the patch in #15 is RTBC. The dependency injection changes from #8 to #14 are out of scope for the D9, but they are good.

+++ b/src/FacebookEventInterface.php
@@ -3,9 +3,7 @@
+ * Defines the interface for facebook_pixel_commerce service.

Copy/paste error, this should be "facebook_pixel service." - I've fixed this in the attached patch.

  • andyg5000 committed 9834e50 on 8.x-1.x authored by chuyenlv 
    Issue #3122781 by GaëlG, chuyenlv, fenstrat, mo_farhaz, tushar.verma,...
andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.