FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/src/Form/ReaderChapterFormAlter.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
31 | ERROR | [ ] Type hint "array" missing for $form
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/src/Form/ReaderPublicationFormAlter.php
----------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------
12 | WARNING | [x] Unused use statement
31 | ERROR | [ ] Type hint "array" missing for $form
53 | ERROR | [x] Data types in @var tags need to be fully namespaced
101 | ERROR | [x] Expected 1 blank line after function; 0 found
102 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/src/Entity/ReaderEntityCrossReference.php
------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------
15 | ERROR | [x] Data types in @param tags need to be fully namespaced
17 | ERROR | [x] Data types in @param tags need to be fully namespaced
29 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
50 | ERROR | [x] Data types in @param tags need to be fully namespaced
57 | ERROR | [ ] Type hint "array" missing for $chapter_nids
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/src/Batch/ReaderChapterExtractorBatchProcessor.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Doc comment short description must end with a full stop
21 | ERROR | [ ] Doc comment for parameter $reader_publication_id does not match actual variable name
27 | ERROR | [ ] Type hint "array" missing for $context
99 | ERROR | [ ] Doc comment for parameter $reader_publication_id does not match actual variable name
102 | ERROR | [ ] @return doc comment specified, but function has no return statement
107 | ERROR | [ ] Type hint "array" missing for $context
125 | ERROR | [ ] Missing parameter type
128 | ERROR | [ ] @return doc comment specified, but function has no return statement
162 | ERROR | [ ] Type hint "array" missing for $results
162 | ERROR | [ ] Type hint "array" missing for $operations
165 | WARNING | [ ] The use of function dvm() is discouraged
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/src/Epub/ReaderEpubCompletedCleanup.php
----------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 3 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace declaration
6 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
20 | ERROR | [x] Data types in @param tags need to be fully namespaced
20 | ERROR | [x] Data types in @param tags need to be fully namespaced
27 | ERROR | [ ] Type hint "array" missing for $chapter_ids
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/src/Epub/ReaderEpubXhtmlConverter.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 11 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
18 | ERROR | [x] Data types in @param tags need to be fully namespaced
18 | ERROR | [x] Data types in @param tags need to be fully namespaced
39 | ERROR | [x] No space found before comment text; expected "// $title = $this->getTitle($crawler, $chapter_xhtml_uri, $chapter_id);" but found "//$title =
| | $this->getTitle($crawler, $chapter_xhtml_uri, $chapter_id);"
39 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
67 | ERROR | [ ] Parameter $crawler is not described in comment
70 | ERROR | [ ] Missing parameter type
72 | ERROR | [ ] Missing parameter type
75 | ERROR | [ ] Description for the @return value is missing
97 | ERROR | [ ] Missing parameter type
112 | ERROR | [x] Data types in @var tags need to be fully namespaced
112 | ERROR | [x] Data types in @var tags need to be fully namespaced
124 | ERROR | [ ] Missing parameter type
126 | ERROR | [ ] Missing parameter type
135 | ERROR | [x] Data types in @var tags need to be fully namespaced
135 | ERROR | [x] Data types in @var tags need to be fully namespaced
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/src/Epub/ReaderEpubZipExtractor.php
------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace declaration
43 | ERROR | [x] Data types in @param tags need to be fully namespaced
142 | ERROR | [ ] Arguments with default values must be at the end of the argument list
163 | ERROR | [ ] Doc comment for parameter $types does not match actual variable name
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/src/Event/ReaderEpubXhmlConverterEvent.php
-------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------
19 | ERROR | [x] Data types in @var tags need to be fully namespaced
26 | ERROR | [x] Data types in @var tags need to be fully namespaced
33 | ERROR | [x] Data types in @var tags need to be fully namespaced
40 | ERROR | [x] Data types in @param tags need to be fully namespaced
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/epub_reader_framework.module
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
30 | ERROR | epub_reader_framework_requirements() is an installation hook and must be declared in an install file
-------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/README.md
----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 115 characters
10 | WARNING | Line exceeds 80 characters; contains 172 characters
----------------------------------------------------------------------------------
FILE: /var/www/html/drupal-contrib/modules/contrib/epub_reader_framework/epub_reader_framework.info.yml
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3122764-2.patch | 11.6 KB | prabha1997 |
Comments
Comment #2
prabha1997 commentedKindly review patch
Comment #3
shaktikComment #4
scott_euser commentedThanks for your contributions! Unfortunately this patch no longer applies particularly with all the changes in https://www.drupal.org/project/epub_reader_framework/issues/3122767
I might recommend waiting a bit, as this is going to be a moving target for a bit while its under active development on dev over the next couple weeks.
Comment #5
scott_euser commentedComment #6
scott_euser commentedHas been fixed on 2.x