CommentFileSizeAuthor
#6 interdiff-2-6.txt4.4 KBnaresh_bavaskar
#6 3122755-6.patch5.46 KBnaresh_bavaskar
#2 3122755-2.patch1.45 KBkuldeep_mehra27

Comments

kuldeep_mehra27 created an issue. See original summary.

kuldeep_mehra27’s picture

kuldeep_mehra27 commented
Assigned: kuldeep_mehra27 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3122755-2.patch1.45 KB
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: Unassigned » naresh_bavaskar
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: naresh_bavaskar » Unassigned
Status: Needs review » Needs work

File: "src/Plugin/views/filter/SearchApiJtsFilter.php" also needs to replace with $this->t().

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: Unassigned » naresh_bavaskar
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: naresh_bavaskar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3122755-6.patch5.46 KB
new interdiff-2-6.txt4.4 KB

I have replaced with $this->t() along with removed unused variables in this patch...pls review anyone

  • aleix committed 21c8856 on 8.x-1.x authored by naresh_bavaskar 
    Issue #3122755 by naresh_bavaskar, kuldeep_mehra27: t() calls should be...
aleix’s picture

aleix
Primary language Catalan
Location Terrassa
commented
Status: Needs review » Fixed

Patch not used but anyway attribution done as you work a little :) .thank's for reporting

aleix’s picture

aleix
Primary language Catalan
Location Terrassa
commented
Version: » 8.x-1.x-dev
Status: Fixed » Closed (fixed)