Add core_version_requirement: ^8 || ^9 to form_placeholder.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#9 Fix-compatible-with-Drupal-9-3122481-3.patch420 byteshieuntnguyen
#2 drupal9-readiness-3122481-2.patch416 bytesmo_farhaz

Issue fork form_placeholder-3122481

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal9-readiness-3122481-2.patch416 bytes

Please review it.

kapilv’s picture

kapilv commented
Issue tags: +Drupal 9 compatibility
hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs review » Reviewed & tested by the community

patch #2 applies cleanly and installed this on Drupal 9 instance.

Ran drupal-check and found no issues:

drupal-check -ad modules/contrib/form_placeholder                                       
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 24 MB of memory.


To avoid this issue, allow to use more memory with the --memory-limit option.
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] No errors
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

  • pifagor committed b6907df on 8.x-1.x authored by mo_farhaz 
    Issue #3122481 by mo_farhaz, kapilkumar0324, Hardik_Patel_12, pifagor:...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hieuntnguyen’s picture

hieuntnguyen commented
StatusFileSize
new Fix-compatible-with-Drupal-9-3122481-3.patch420 bytes

alexismmd made their first commit to this issue’s fork.

alexismmd opened merge request !3