Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
First noticed by @alexpott in #3072076-55: JSON:API returns a CacheableResponseInterface instance for non-cacheable methods; causes unnecessary exceptions., the JSON:API module has many @see links (and similar) that are still targeting JSON:API issue in the contrib project. They need to point to Drupal core issues (and those issue may need to be moved to the core queue).
Proposed resolution
Identify and update the links in the codebase and convert all contrib-only issues to Drupal core issues.
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Release notes snippet
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | 3122113-8.9.x-22.patch | 90.26 KB | bbrala |
| #24 | interdiff-11-22.txt | 2.53 KB | bbrala |
| #19 | interdiff_16-19.txt | 1.07 KB | suresh prabhu parkala |
| #19 | 3122113-19.patch | 89.22 KB | suresh prabhu parkala |
| #16 | 3122113-16.patch | 87.85 KB | suresh prabhu parkala |
Comments
Comment #3
gabesulliceCrediting @alexpott for identifying this issue.
Comment #4
gabesulliceComment #5
rpayanmHi,
I'll search by "https://www.drupal.org/project/jsonapi/" and I'll change to the correct url (Drupal core issue).
Comment #6
rpayanmI moved all issues in the @see section from jsonapi project to Drupal core.
I don't know why this didn't change the url:
https://www.drupal.org/project/jsonapi/issues/2922121
Comment #7
ilgnerfagundes commentedFor me the links are correct
Comment #8
gabesulliceIt looks like the patch no longer applies. @rpayanm, can you roll a new one?
Comment #9
suresh prabhu parkala commentedHere is a new patch.
Comment #10
rpayanmComment #11
rpayanmI had to add --binary option when I created the patch.
Comment #12
rkbrasse commentedThe patch applied with no issues. To test, I searched core for the string "project/jsonapi/issues," and there were none present. I also verified several of the replacements now pointed to core/issues.
Comment #13
tolu_ commentednice
Comment #15
xjmThis doesn't apply to 9.1.x, so we need a 9.x version.
I reviewed the 8.9.x version of #11 locally with
git diff --color-wordsand it all looks good!As a docs fix, this is backportable as far as 8.8. (Use the "test with" select field next to the upload button for each respective branch's patch.)
Comment #16
suresh prabhu parkala commentedPatch for 9.1.x version. Please review.
Comment #18
bbralaThought i go through the reroll but onfortunately there were a few lines you forgot.
core/modules/jsonapi/src/JsonApiResource/JsonApiDocumentTopLevel.phpcore/modules/jsonapi/tests/src/Functional/MenuLinkContentTest.php line 176Small changes :)
Comment #19
suresh prabhu parkala commentedUpdated as mention in #18. Please review!
Comment #20
bbralaThe patch for 9.1 is good like this, well done!
Committer; the 8.9.x patch does need to be the specific one since there is one file that doesn't exist in 9.1.x (
Drupal\Tests\jsonapi\Functional\Update\ReadOnlyModeUpdateTest). Don't be fooled by the test on #19.Comment #21
catchCommitted/pushed to 9.1.x and 9.0.x
This is eligible for backport to 8.9.x, but the patch in #11 no longer applies. Going to mark this fixed, but feel free to re-open with an 8.9.x re-roll.
Comment #24
bbrala@catch I've rerolled the 8.9.x patch.
Comment #25
catchComment #27
catchCommitted a8ec557 and pushed to 8.9.x. Thanks!